Skip to content

Commit 872c744

Browse files
Update checkstyle plugin version and remove no longer supported checkstyle module "RedundantThrows".
Make checkstyle run outside of the maven site lifecyle use checkstyle.xml. Enable checkstyle on travis-ci.
1 parent d357d9d commit 872c744

3 files changed

Lines changed: 12 additions & 6 deletions

File tree

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jdk:
2222
- oraclejdk8
2323

2424
script:
25-
- mvn test apache-rat:check clirr:check javadoc:javadoc
25+
- mvn test apache-rat:check clirr:check checkstyle:check javadoc:javadoc
2626

2727
after_success:
2828
- mvn clean cobertura:cobertura coveralls:report

checkstyle.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@ limitations under the License.
3636
<module name="RedundantImport"/>
3737
<module name="UnusedImports"/>
3838
<module name="NeedBraces"/>
39-
<module name="RedundantThrows">
40-
<property name="allowUnchecked" value="true"/>
41-
<property name="allowSubclasses" value="true"/>
42-
</module>
4339
<module name="LineLength">
4440
<property name="max" value="160"/>
4541
</module>

pom.xml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ file comparators, endian transformation classes, and much more.
261261
<commons.scmPubCheckoutDirectory>site-content</commons.scmPubCheckoutDirectory>
262262
<!-- Override clirr version to be able to build the site on Java 8 -->
263263
<commons.clirr.version>2.8</commons.clirr.version>
264+
<checkstyle.plugin.version>2.17</checkstyle.plugin.version>
264265
</properties>
265266

266267
<build>
@@ -312,6 +313,15 @@ file comparators, endian transformation classes, and much more.
312313
<tarLongFileMode>gnu</tarLongFileMode>
313314
</configuration>
314315
</plugin>
316+
<plugin>
317+
<groupId>org.apache.maven.plugins</groupId>
318+
<artifactId>maven-checkstyle-plugin</artifactId>
319+
<version>${checkstyle.plugin.version}</version>
320+
<configuration>
321+
<configLocation>${basedir}/checkstyle.xml</configLocation>
322+
<enableRulesSummary>false</enableRulesSummary>
323+
</configuration>
324+
</plugin>
315325
<plugin>
316326
<groupId>org.apache.maven.plugins</groupId>
317327
<artifactId>maven-scm-publish-plugin</artifactId>
@@ -334,7 +344,7 @@ file comparators, endian transformation classes, and much more.
334344
<plugin>
335345
<groupId>org.apache.maven.plugins</groupId>
336346
<artifactId>maven-checkstyle-plugin</artifactId>
337-
<version>2.12.1</version>
347+
<version>${checkstyle.plugin.version}</version>
338348
<configuration>
339349
<configLocation>${basedir}/checkstyle.xml</configLocation>
340350
<enableRulesSummary>false</enableRulesSummary>

0 commit comments

Comments
 (0)