MessageDigestCalculatingInputStream.MessageDigestMaintainingObserver.MessageDigestMaintainingObserver(MessageDigest)

now throws a NullPointerException if the MessageDigest is null

MessageDigestCalculatingInputStream.MessageDigestCalculatingInputStream(InputStream,
MessageDigest) now throws a NullPointerException if the MessageDigest is
null

Author: garydgregory

src/changes/changes.xml

@@ -97,6 +97,14 @@ The <action> type attribute can be add,update,fix,remove.
       <action dev="ggregory" type="fix" due-to="Gary Gregory">
         Fix CodeQL warnings in UnsynchronizedBufferedInputStream: Implicit narrowing conversion in compound assignment.
       </action>
+      <action dev="ggregory" type="fix" due-to="Gary Gregory">
+        MessageDigestCalculatingInputStream.MessageDigestMaintainingObserver.MessageDigestMaintainingObserver(MessageDigest) now throws a NullPointerException
+        if the MessageDigest is null.
+      </action>
+      <action dev="ggregory" type="fix" due-to="Gary Gregory">
+        MessageDigestCalculatingInputStream.MessageDigestCalculatingInputStream(InputStream, MessageDigest) now throws a NullPointerException
+        if the MessageDigest is null.
+      </action>
       <!-- ADD -->
       <action dev="ggregory" type="add" due-to="Gary Gregory">
         Add org.apache.commons.io.channels.FileChannels.

src/main/java/org/apache/commons/io/input/MessageDigestCalculatingInputStream.java

@@ -21,6 +21,7 @@
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
 import java.security.Provider;
+import java.util.Objects;
 
 import org.apache.commons.io.build.AbstractStreamBuilder;
 
@@ -126,9 +127,10 @@ public static class MessageDigestMaintainingObserver extends Observer {
          * Constructs an MessageDigestMaintainingObserver for the given MessageDigest.
          *
          * @param messageDigest the message digest to use
+         * @throws NullPointerException if messageDigest is null.
          */
         public MessageDigestMaintainingObserver(final MessageDigest messageDigest) {
-            this.messageDigest = messageDigest;
+            this.messageDigest = Objects.requireNonNull(messageDigest, "messageDigest");
         }
 
         @Override
@@ -193,6 +195,7 @@ public MessageDigestCalculatingInputStream(final InputStream inputStream) throws
      *
      * @param inputStream   the stream to calculate the message digest for
      * @param messageDigest the message digest to use
+     * @throws NullPointerException if messageDigest is null.
      * @deprecated Use {@link #builder()}, {@link Builder}, and {@link Builder#get()}.
      */
     @Deprecated