IO-107 - Increase test robustness for openOutputStream

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/io/trunk@490988 13f79535-47bb-0310-9956-ffa450edef68

Author: Stephen Colebourne

src/test/org/apache/commons/io/FileUtilsTestCase.java

@@ -119,11 +119,14 @@ public void test_openOutputStream_exists() throws Exception {
     public void test_openOutputStream_existsButIsDirectory() throws Exception {
         File directory = new File(getTestDirectory(), "subdir");
         directory.mkdirs();
+        FileOutputStream out = null;
         try {
-            FileUtils.openOutputStream(directory);
+            out = FileUtils.openOutputStream(directory);
             fail();
         } catch (IOException ioe) {
             // expected
+        } finally {
+            IOUtils.closeQuietly(out);
         }
     }
 
@@ -140,12 +143,23 @@ public void test_openOutputStream_notExists() throws Exception {
     }
 
     public void test_openOutputStream_notExistsCannotCreate() throws Exception {
-        File file = new File(getTestDirectory(), "a/:#$!/test.txt");  // empty path segment is bad directory name
+        // according to Wikipedia, most filing systems have a 256 limit on filename
+        String longStr =
+            "abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz" +
+            "abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz" +
+            "abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz" +
+            "abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz" +
+            "abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz" +
+            "abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz";  // 300 chars
+        File file = new File(getTestDirectory(), "a/" + longStr + "/test.txt");
+        FileOutputStream out = null;
         try {
-            FileUtils.openOutputStream(file);
+            out = FileUtils.openOutputStream(file);
             fail();
         } catch (IOException ioe) {
             // expected
+        } finally {
+            IOUtils.closeQuietly(out);
         }
     }