Skip to content

Commit aef6472

Browse files
committed
Use StandardCharsets instead of magic string
1 parent 0abbea9 commit aef6472

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/test/java/org/apache/commons/io/CharsetsTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,27 +98,27 @@ public void testToCharset_String_Charset() {
9898

9999
@Test
100100
public void testUsAscii() {
101-
assertEquals("US-ASCII", Charsets.US_ASCII.name());
101+
assertEquals(StandardCharsets.US_ASCII.name(), Charsets.US_ASCII.name());
102102
}
103103

104104
@Test
105105
public void testUtf16() {
106-
assertEquals("UTF-16", Charsets.UTF_16.name());
106+
assertEquals(StandardCharsets.UTF_16.name(), Charsets.UTF_16.name());
107107
}
108108

109109
@Test
110110
public void testUtf16Be() {
111-
assertEquals("UTF-16BE", Charsets.UTF_16BE.name());
111+
assertEquals(StandardCharsets.UTF_16BE.name(), Charsets.UTF_16BE.name());
112112
}
113113

114114
@Test
115115
public void testUtf16Le() {
116-
assertEquals("UTF-16LE", Charsets.UTF_16LE.name());
116+
assertEquals(StandardCharsets.UTF_16LE.name(), Charsets.UTF_16LE.name());
117117
}
118118

119119
@Test
120120
public void testUtf8() {
121-
assertEquals("UTF-8", Charsets.UTF_8.name());
121+
assertEquals(StandardCharsets.UTF_8.name(), Charsets.UTF_8.name());
122122
}
123123

124124
}

src/test/java/org/apache/commons/io/IOUtilsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1753,7 +1753,7 @@ public void testWriteBigString() throws IOException {
17531753
public void testWriteLines() throws IOException {
17541754
final String[] data = {"The", "quick"};
17551755
final ByteArrayOutputStream out = new ByteArrayOutputStream();
1756-
IOUtils.writeLines(Arrays.asList(data), "\n", out, "UTF-16");
1756+
IOUtils.writeLines(Arrays.asList(data), "\n", out, StandardCharsets.UTF_16.name());
17571757
final String result = new String(out.toByteArray(), StandardCharsets.UTF_16);
17581758
assertEquals("The\nquick\n", result);
17591759
}

0 commit comments

Comments
 (0)