Enable SpotBugs in the default Maven goal

Author: garydgregory

pom.xml

@@ -353,7 +353,7 @@ file comparators, endian transformation classes, and much more.
 
   <build>
     <!-- japicmp:cmp needs package to work from a jar -->
-    <defaultGoal>clean verify apache-rat:check japicmp:cmp checkstyle:check pmd:check javadoc:javadoc</defaultGoal>
+    <defaultGoal>clean verify apache-rat:check japicmp:cmp checkstyle:check spotbugs:check pmd:check javadoc:javadoc</defaultGoal>
     <pluginManagement>
       <plugins>
         <plugin>

src/conf/spotbugs-exclude-filter.xml

@@ -20,6 +20,16 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
 
+  <!-- TODO Can any of these be done without breaking binary compatibility? -->
+  <Match>
+    <Class name="~.*" />
+    <Or>
+      <Bug pattern="EI_EXPOSE_REP" />
+      <Bug pattern="EI_EXPOSE_REP2" />
+      <Bug pattern="MS_EXPOSE_REP" />
+    </Or>
+  </Match>
+
   <!--  See discussion on https://issues.apache.org/jira/browse/IO-216 -->
   <Match>
     <Class name="org.apache.commons.io.output.LockableFileWriter" />
@@ -47,4 +57,25 @@
     <Bug pattern="MS_PKGPROTECT" />
   </Match>
 
+  <!-- Deprecated -->
+  <Match>
+    <Class name="org.apache.commons.io.monitor.FileAlterationObserver" />
+    <Field name="fileFilter" />
+    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
+  </Match>
+
+  <!-- Deprecated -->
+  <Match>
+    <Class name="org.apache.commons.io.monitor.FileAlterationObserver" />
+    <Field name="listeners" />
+    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
+  </Match>
+
+  <!-- This class only throws unchecked exceptions. -->
+  <Match>
+    <Class name="org.apache.commons.io.function.UncheckedIOIterator" />
+    <Method name="next" />
+    <Bug pattern="IT_NO_SUCH_ELEMENT" />
+  </Match>
+
 </FindBugsFilter>