Add Checkstyle RedundantModifier

Author: garydgregory

src/conf/checkstyle.xml

@@ -61,6 +61,7 @@ limitations under the License.
     <module name="NeedBraces" />
     <module name="ParenPad" />
     <module name="RedundantImport" />
+    <module name="RedundantModifier" />
     <!-- No Trailing whitespace -->
     <module name="Regexp">
       <property name="format" value="[ \t]+$" />

src/main/java/org/apache/commons/io/comparator/ReverseFileComparator.java

@@ -40,7 +40,7 @@ final class ReverseFileComparator extends AbstractFileComparator implements Seri
      *
      * @param delegate The comparator to delegate to.
      */
-    public ReverseFileComparator(final Comparator<File> delegate) {
+    ReverseFileComparator(final Comparator<File> delegate) {
         this.delegate = Objects.requireNonNull(delegate, "delegate");
     }
 

src/main/java/org/apache/commons/io/function/IOFunction.java

@@ -114,7 +114,7 @@ default <V> IOFunction<T, V> andThen(final IOFunction<? super R, ? extends V> af
      * @return the function result
      * @throws IOException if an I/O error occurs.
      */
-    R apply(final T t) throws IOException;
+    R apply(T t) throws IOException;
 
     /**
      * Creates a {@link Function} for this instance that throws {@link UncheckedIOException} instead of {@link IOException}.

src/main/java/org/apache/commons/io/input/Tailer.java

@@ -370,7 +370,7 @@ public interface RandomAccessResourceBridge extends Closeable {
          * @throws IOException If the first byte cannot be read for any reason other than end of tailable, or if the random
          *         access tailable has been closed, or if some other I/O error occurs.
          */
-        int read(final byte[] b) throws IOException;
+        int read(byte[] b) throws IOException;
 
         /**
          * Sets the file-pointer offset, measured from the beginning of this tailable, at which the next read or write occurs.
@@ -382,7 +382,7 @@ public interface RandomAccessResourceBridge extends Closeable {
          *        pointer.
          * @throws IOException if {@code pos} is less than {@code 0} or if an I/O error occurs.
          */
-        void seek(final long pos) throws IOException;
+        void seek(long pos) throws IOException;
     }
 
     /**
@@ -399,7 +399,7 @@ public interface Tailable {
          * @return a random access file stream to read.
          * @throws FileNotFoundException if the tailable object does not exist.
          */
-        RandomAccessResourceBridge getRandomAccess(final String mode) throws FileNotFoundException;
+        RandomAccessResourceBridge getRandomAccess(String mode) throws FileNotFoundException;
 
         /**
          * Tests if this tailable is newer than the specified {@link FileTime}.
@@ -408,7 +408,7 @@ public interface Tailable {
          * @return true if the {@link File} exists and has been modified after the given {@link FileTime}.
          * @throws IOException if an I/O error occurs.
          */
-        boolean isNewer(final FileTime fileTime) throws IOException;
+        boolean isNewer(FileTime fileTime) throws IOException;
 
         /**
          * Gets the last modification {@link FileTime}.

src/main/java/org/apache/commons/io/monitor/FileAlterationListener.java

@@ -33,54 +33,54 @@ public interface FileAlterationListener {
      *
      * @param directory The directory changed
      */
-    void onDirectoryChange(final File directory);
+    void onDirectoryChange(File directory);
 
     /**
      * Directory created Event.
      *
      * @param directory The directory created
      */
-    void onDirectoryCreate(final File directory);
+    void onDirectoryCreate(File directory);
 
     /**
      * Directory deleted Event.
      *
      * @param directory The directory deleted
      */
-    void onDirectoryDelete(final File directory);
+    void onDirectoryDelete(File directory);
 
     /**
      * File changed Event.
      *
      * @param file The file changed
      */
-    void onFileChange(final File file);
+    void onFileChange(File file);
 
     /**
      * File created Event.
      *
      * @param file The file created
      */
-    void onFileCreate(final File file);
+    void onFileCreate(File file);
 
     /**
      * File deleted Event.
      *
      * @param file The file deleted
      */
-    void onFileDelete(final File file);
+    void onFileDelete(File file);
 
     /**
      * File system observer started checking event.
      *
      * @param observer The file system observer
      */
-    void onStart(final FileAlterationObserver observer);
+    void onStart(FileAlterationObserver observer);
 
     /**
      * File system observer finished checking event.
      *
      * @param observer The file system observer
      */
-    void onStop(final FileAlterationObserver observer);
+    void onStop(FileAlterationObserver observer);
 }

src/main/java/org/apache/commons/io/monitor/SerializableFileTime.java

@@ -43,7 +43,7 @@ final class SerializableFileTime implements Serializable {
 
     private FileTime fileTime;
 
-    public SerializableFileTime(final FileTime fileTime) {
+    SerializableFileTime(final FileTime fileTime) {
         this.fileTime = Objects.requireNonNull(fileTime);
     }
 

src/main/java/org/apache/commons/io/output/AbstractByteArrayOutputStream.java

@@ -77,7 +77,7 @@ protected interface InputStreamConstructor<T extends InputStream> {
          * @param length the length of the buffer
          * @return the InputStream subclass.
          */
-        T construct(final byte[] buffer, final int offset, final int length);
+        T construct(byte[] buffer, int offset, int length);
     }
 
     static final int DEFAULT_SIZE = 1024;
@@ -330,7 +330,7 @@ public void write(final byte b[]) {
     }
 
     @Override
-    public abstract void write(final byte[] b, final int off, final int len);
+    public abstract void write(byte[] b, int off, int len);
 
     /**
      * Writes the bytes for given CharSequence encoded using a Charset.
@@ -356,10 +356,10 @@ public T write(final CharSequence data, final Charset charset) {
      * @throws IOException if an I/O error occurs while reading the input stream
      * @since 1.4
      */
-    public abstract int write(final InputStream in) throws IOException;
+    public abstract int write(InputStream in) throws IOException;
 
     @Override
-    public abstract void write(final int b);
+    public abstract void write(int b);
 
     /**
      * Writes the bytes to the byte array.
@@ -433,7 +433,7 @@ protected void writeImpl(final int b) {
      * @throws IOException if an I/O error occurs, such as if the stream is closed
      * @see java.io.ByteArrayOutputStream#writeTo(OutputStream)
      */
-    public abstract void writeTo(final OutputStream out) throws IOException;
+    public abstract void writeTo(OutputStream out) throws IOException;
 
     /**
      * Writes the entire contents of this byte stream to the

src/main/java/org/apache/commons/io/serialization/FullClassNameMatcher.java

@@ -38,7 +38,7 @@ final class FullClassNameMatcher implements ClassNameMatcher {
      *
      * @param classes a list of class names
      */
-    public FullClassNameMatcher(final String... classes) {
+    FullClassNameMatcher(final String... classes) {
         classesSet = Collections.unmodifiableSet(new HashSet<>(Arrays.asList(classes)));
     }
 

src/main/java/org/apache/commons/io/serialization/RegexpClassNameMatcher.java

@@ -37,7 +37,7 @@ final class RegexpClassNameMatcher implements ClassNameMatcher {
      * @param pattern a pattern for evaluating acceptable class names
      * @throws NullPointerException if {@code pattern} is null
      */
-    public RegexpClassNameMatcher(final Pattern pattern) {
+    RegexpClassNameMatcher(final Pattern pattern) {
         this.pattern = Objects.requireNonNull(pattern, "pattern");
     }
 
@@ -46,7 +46,7 @@ public RegexpClassNameMatcher(final Pattern pattern) {
      *
      * @param regex a regular expression for evaluating acceptable class names
      */
-    public RegexpClassNameMatcher(final String regex) {
+    RegexpClassNameMatcher(final String regex) {
         this(Pattern.compile(regex));
     }
 

src/main/java/org/apache/commons/io/serialization/WildcardClassNameMatcher.java

@@ -36,7 +36,7 @@ final class WildcardClassNameMatcher implements ClassNameMatcher {
      *
      * @param pattern a {@link FilenameUtils#wildcardMatch} pattern.
      */
-    public WildcardClassNameMatcher(final String pattern) {
+    WildcardClassNameMatcher(final String pattern) {
         this.pattern = pattern;
     }