Skip to content

Commit ce9deab

Browse files
committed
Fix warnings
1 parent d97c3bd commit ce9deab

1 file changed

Lines changed: 12 additions & 11 deletions

File tree

src/test/java/org/apache/commons/io/output/ByteArrayOutputStreamTestCase.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,15 @@ private void checkStreams(
104104

105105
@ParameterizedTest(name = "[{index}] {0}")
106106
@MethodSource("baosFactories")
107-
public void testWriteZero(final String baosName, final BAOSFactory baosFactory) {
107+
public void testWriteZero(final String baosName, final BAOSFactory<?> baosFactory) {
108108
final AbstractByteArrayOutputStream baout = baosFactory.instance();
109109
baout.write(new byte[0], 0, 0);
110+
assertTrue(true, "Dummy");
110111
}
111112

112113
@ParameterizedTest(name = "[{index}] {0}")
113114
@MethodSource("baosFactories")
114-
public void testInvalidWriteOffsetUnder(final String baosName, final BAOSFactory baosFactory) {
115+
public void testInvalidWriteOffsetUnder(final String baosName, final BAOSFactory<?> baosFactory) {
115116
final AbstractByteArrayOutputStream baout = baosFactory.instance();
116117
assertThrows(IndexOutOfBoundsException.class, () ->
117118
baout.write(null, -1, 0)
@@ -120,7 +121,7 @@ public void testInvalidWriteOffsetUnder(final String baosName, final BAOSFactory
120121

121122
@ParameterizedTest(name = "[{index}] {0}")
122123
@MethodSource("baosFactories")
123-
public void testInvalidWriteOffsetOver(final String baosName, final BAOSFactory baosFactory) {
124+
public void testInvalidWriteOffsetOver(final String baosName, final BAOSFactory<?> baosFactory) {
124125
final AbstractByteArrayOutputStream baout = baosFactory.instance();
125126
assertThrows(IndexOutOfBoundsException.class, () ->
126127
baout.write(new byte[0], 1, 0)
@@ -129,7 +130,7 @@ public void testInvalidWriteOffsetOver(final String baosName, final BAOSFactory
129130

130131
@ParameterizedTest(name = "[{index}] {0}")
131132
@MethodSource("baosFactories")
132-
public void testInvalidWriteLenUnder(final String baosName, final BAOSFactory baosFactory) {
133+
public void testInvalidWriteLenUnder(final String baosName, final BAOSFactory<?> baosFactory) {
133134
final AbstractByteArrayOutputStream baout = baosFactory.instance();
134135
assertThrows(IndexOutOfBoundsException.class, () ->
135136
baout.write(new byte[1], 0, -1)
@@ -138,7 +139,7 @@ public void testInvalidWriteLenUnder(final String baosName, final BAOSFactory ba
138139

139140
@ParameterizedTest(name = "[{index}] {0}")
140141
@MethodSource("baosFactories")
141-
public void testInvalidWriteOffsetAndLenUnder(final String baosName, final BAOSFactory baosFactory) {
142+
public void testInvalidWriteOffsetAndLenUnder(final String baosName, final BAOSFactory<?> baosFactory) {
142143
final AbstractByteArrayOutputStream baout = baosFactory.instance();
143144
assertThrows(IndexOutOfBoundsException.class, () ->
144145
baout.write(new byte[1], 1, -2)
@@ -147,7 +148,7 @@ public void testInvalidWriteOffsetAndLenUnder(final String baosName, final BAOSF
147148

148149
@ParameterizedTest(name = "[{index}] {0}")
149150
@MethodSource("baosFactories")
150-
public void testInvalidWriteOffsetAndLenOver(final String baosName, final BAOSFactory baosFactory) {
151+
public void testInvalidWriteOffsetAndLenOver(final String baosName, final BAOSFactory<?> baosFactory) {
151152
final AbstractByteArrayOutputStream baout = baosFactory.instance();
152153
assertThrows(IndexOutOfBoundsException.class, () ->
153154
baout.write(new byte[1], 0, 2)
@@ -156,15 +157,15 @@ public void testInvalidWriteOffsetAndLenOver(final String baosName, final BAOSFa
156157

157158
@ParameterizedTest(name = "[{index}] {0}")
158159
@MethodSource("baosFactories")
159-
public void testInvalidParameterizedConstruction(final String baosName, final BAOSFactory baosFactory) {
160+
public void testInvalidParameterizedConstruction(final String baosName, final BAOSFactory<?> baosFactory) {
160161
assertThrows(IllegalArgumentException.class, () ->
161162
baosFactory.instance(-1)
162163
);
163164
}
164165

165166
@ParameterizedTest(name = "[{index}] {0}")
166167
@MethodSource("baosFactories")
167-
public void testToInputStreamEmpty(final String baosName, final BAOSFactory baosFactory) throws IOException {
168+
public void testToInputStreamEmpty(final String baosName, final BAOSFactory<?> baosFactory) throws IOException {
168169
final AbstractByteArrayOutputStream baout = baosFactory.instance();
169170

170171
//Get data before more writes
@@ -208,7 +209,7 @@ public void testToBufferedInputStream(final String baosName, final IOFunction<In
208209

209210
@ParameterizedTest(name = "[{index}] {0}")
210211
@MethodSource("baosFactories")
211-
public void testToInputStream(final String baosName, final BAOSFactory baosFactory) throws IOException {
212+
public void testToInputStream(final String baosName, final BAOSFactory<?> baosFactory) throws IOException {
212213
final AbstractByteArrayOutputStream baout = baosFactory.instance();
213214
final java.io.ByteArrayOutputStream ref = new java.io.ByteArrayOutputStream();
214215

@@ -241,7 +242,7 @@ public void testToInputStream(final String baosName, final BAOSFactory baosFacto
241242

242243
@ParameterizedTest(name = "[{index}] {0}")
243244
@MethodSource("baosFactories")
244-
public void testToInputStreamWithReset(final String baosName, final BAOSFactory baosFactory) throws IOException {
245+
public void testToInputStreamWithReset(final String baosName, final BAOSFactory<?> baosFactory) throws IOException {
245246
//Make sure reset() do not destroy InputStream returned from toInputStream()
246247
final AbstractByteArrayOutputStream baout = baosFactory.instance();
247248
final java.io.ByteArrayOutputStream ref = new java.io.ByteArrayOutputStream();
@@ -277,7 +278,7 @@ public void testToInputStreamWithReset(final String baosName, final BAOSFactory
277278

278279
@ParameterizedTest(name = "[{index}] {0}")
279280
@MethodSource("baosFactories")
280-
public void testStream(final String baosName, final BAOSFactory baosFactory) throws Exception {
281+
public void testStream(final String baosName, final BAOSFactory<?> baosFactory) throws Exception {
281282
int written;
282283

283284
//The ByteArrayOutputStream is initialized with 32 bytes to match

0 commit comments

Comments
 (0)