Skip to content

Commit d6324ee

Browse files
committed
No need to allocate empty File arrays over and over.
1 parent 5fcb8cc commit d6324ee

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import java.util.List;
2828
import java.util.Set;
2929

30+
import org.apache.commons.io.FileUtils;
3031
import org.apache.commons.io.IOCase;
3132

3233
/**
@@ -78,7 +79,7 @@ public static File[] filter(final IOFileFilter filter, final File... files) {
7879
throw new IllegalArgumentException("file filter is null");
7980
}
8081
if (files == null) {
81-
return new File[0];
82+
return FileUtils.EMPTY_FILE_ARRAY;
8283
}
8384
final List<File> acceptedFiles = new ArrayList<>();
8485
for (final File file : files) {
@@ -89,7 +90,7 @@ public static File[] filter(final IOFileFilter filter, final File... files) {
8990
acceptedFiles.add(file);
9091
}
9192
}
92-
return acceptedFiles.toArray(new File[0]);
93+
return acceptedFiles.toArray(FileUtils.EMPTY_FILE_ARRAY);
9394
}
9495

9596
/**
@@ -120,7 +121,7 @@ public static File[] filter(final IOFileFilter filter, final File... files) {
120121
*/
121122
public static File[] filter(final IOFileFilter filter, final Iterable<File> files) {
122123
final List<File> acceptedFiles = filterList(filter, files);
123-
return acceptedFiles.toArray(new File[0]);
124+
return acceptedFiles.toArray(FileUtils.EMPTY_FILE_ARRAY);
124125
}
125126

126127
/**

0 commit comments

Comments
 (0)