Inline single use local variable before a return

garydgregory · garydgregory · commit d76a0b2fae82 · 2025-09-25T10:55:02.000-04:00
diff --git a/src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java b/src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
@@ -128,8 +128,7 @@ private Object getEncoder() {
             if (charsetEncoder != null && getCharset() != null && !charsetEncoder.charset().equals(getCharset())) {
                 throw new IllegalStateException(String.format("Mismatched Charset(%s) and CharsetEncoder(%s)", getCharset(), charsetEncoder.charset()));
             }
-            final Object encoder = charsetEncoder != null ? charsetEncoder : getCharset();
-            return encoder;
+            return charsetEncoder != null ? charsetEncoder : getCharset();
         }
 
         /**

Original file line number	Diff line number	Diff line change
`@@ -128,8 +128,7 @@ private Object getEncoder() {`
`128`	`128`	`if (charsetEncoder != null && getCharset() != null && !charsetEncoder.charset().equals(getCharset())) {`
`129`	`129`	`throw new IllegalStateException(String.format("Mismatched Charset(%s) and CharsetEncoder(%s)", getCharset(), charsetEncoder.charset()));`
`130`	`130`	`}`
`131`		`- final Object encoder = charsetEncoder != null ? charsetEncoder : getCharset();`
`132`		`- return encoder;`
	`131`	`+ return charsetEncoder != null ? charsetEncoder : getCharset();`
`133`	`132`	`}`
`134`	`133`
`135`	`134`	`/**`