Skip to content

Commit e79f0fe

Browse files
committed
Removed examples/ logic from build.xml in the hope gump will build.
Added some more tests to the FileFilter tests. git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/io/trunk@140345 13f79535-47bb-0310-9956-ffa450edef68
1 parent 77fec66 commit e79f0fe

2 files changed

Lines changed: 27 additions & 43 deletions

File tree

build.xml

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
<!--
55
"IO" component of the Jakarta Commons Subproject
6-
$Id: build.xml,v 1.7 2002/12/07 20:33:33 bayard Exp $
6+
$Id: build.xml,v 1.8 2003/01/27 02:22:30 bayard Exp $
77
-->
88

99

@@ -60,9 +60,6 @@
6060
<!-- The base directory for unit test sources -->
6161
<property name="test.home" value="src/test"/>
6262

63-
<!-- The base directory for unit test sources -->
64-
<property name="examples.home" value="src/examples"/>
65-
6663
<!-- ========== Compiler Defaults ========================================= -->
6764

6865

@@ -118,7 +115,6 @@
118115
<mkdir dir="${build.home}/classes"/>
119116
<mkdir dir="${build.home}/conf"/>
120117
<mkdir dir="${build.home}/tests"/>
121-
<mkdir dir="${build.home}/examples"/>
122118
</target>
123119

124120

@@ -160,29 +156,14 @@
160156
</copy>
161157
</target>
162158

163-
<target name="compile.examples" depends="compile"
164-
description="Compile examples">
165-
<javac srcdir="${examples.home}"
166-
destdir="${build.home}/examples"
167-
debug="${compile.debug}"
168-
deprecation="${compile.deprecation}"
169-
optimize="${compile.optimize}">
170-
<classpath refid="compile.classpath"/>
171-
</javac>
172-
<copy todir="${build.home}/examples" filtering="off">
173-
<fileset dir="${examples.home}" excludes="**/*.java"/>
174-
</copy>
175-
</target>
176-
177-
178159
<target name="clean"
179160
description="Clean build and distribution directories">
180161
<delete dir="${build.home}"/>
181162
<delete dir="${dist.home}"/>
182163
</target>
183164

184165

185-
<target name="all" depends="clean,compile, compile.examples"
166+
<target name="all" depends="clean,compile"
186167
description="Clean and compile all components"/>
187168

188169

@@ -216,7 +197,7 @@
216197
</target>
217198

218199

219-
<target name="jar" depends="compile, compile.examples"
200+
<target name="jar" depends="compile"
220201
description="Create jar">
221202
<mkdir dir="${dist.home}"/>
222203
<mkdir dir="${build.home}/classes/META-INF"/>
@@ -225,13 +206,6 @@
225206
<jar jarfile="${dist.home}/commons-${component.name}.jar"
226207
basedir="${build.home}/classes"
227208
manifest="${build.home}/conf/MANIFEST.MF"/>
228-
<mkdir dir="${dist.home}/examples"/>
229-
<mkdir dir="${build.home}/examples/classes/META-INF"/>
230-
<copy file="../LICENSE"
231-
tofile="${build.home}/examples/classes/META-INF/LICENSE.txt"/>
232-
<jar jarfile="${dist.home}/commons-${component.name}-examples.jar"
233-
basedir="${build.home}/examples/classes"
234-
manifest="${build.home}/conf/MANIFEST.MF"/>
235209
</target>
236210

237211

src/test/org/apache/commons/io/filefilter/FileFilterTestCase.java

Lines changed: 24 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*
2-
* $Header: /home/jerenkrantz/tmp/commons/commons-convert/cvs/home/cvs/jakarta-commons//io/src/test/org/apache/commons/io/filefilter/FileFilterTestCase.java,v 1.3 2002/12/25 22:16:05 scolebourne Exp $
3-
* $Revision: 1.3 $
4-
* $Date: 2002/12/25 22:16:05 $
2+
* $Header: /home/jerenkrantz/tmp/commons/commons-convert/cvs/home/cvs/jakarta-commons//io/src/test/org/apache/commons/io/filefilter/FileFilterTestCase.java,v 1.4 2003/01/27 02:22:31 bayard Exp $
3+
* $Revision: 1.4 $
4+
* $Date: 2003/01/27 02:22:31 $
55
*
66
* ====================================================================
77
*
@@ -116,25 +116,35 @@ public void testExtension() throws Exception {
116116
assertFiltering( filter, new File("fred.test"), true);
117117
}
118118

119-
public void testNull() throws Exception {
120-
FileFilter filter = FileFilterUtils.nullFileFilter();
121-
assertFiltering( filter, new File("foo.test"), true);
122-
assertFiltering( filter, new File("foo"), true);
123-
assertFiltering( filter, new File(""), true);
119+
public void testDirectory() throws Exception {
120+
FileFilter filter = new DirectoryFileFilter();
121+
/* These don't like the test for accept(File, String)
122+
assertFiltering( filter, new File("src/"), true);
123+
assertFiltering( filter, new File("src/java/"), true);
124+
*/
125+
assertFiltering( filter, new File("project.xml"), false);
126+
assertFiltering( filter, new File("test"), false);
127+
assertFiltering( filter, new File("test/"), false);
128+
assertFiltering( filter, new File("STATUS.html"), false);
124129
}
125130

126131
public void testPrefix() throws Exception {
127-
FileFilter filter = new PrefixFileFilter("foo");
132+
FileFilter filter = new PrefixFileFilter( new String[] { "foo", "bar" } );
128133
assertFiltering( filter, new File("foo.test"), true);
129134
assertFiltering( filter, new File("foo"), true);
130135
assertFiltering( filter, new File("bar"), false);
136+
assertFiltering( filter, new File("food/"), true);
137+
assertFiltering( filter, new File("barred\\"), true);
138+
assertFiltering( filter, new File("test"), false);
139+
assertFiltering( filter, new File("fo_o.test"), false);
140+
assertFiltering( filter, new File("abar.exe"), false);
131141
}
132142

133-
public void testDirectory() throws Exception {
134-
FileFilter filter = new DirectoryFileFilter();
135-
assertFiltering( filter, new File("src/"), true);
136-
assertFiltering( filter, new File("project.xml"), false);
137-
assertFiltering( filter, new File("src/java/"), true);
143+
public void testNull() throws Exception {
144+
FileFilter filter = FileFilterUtils.nullFileFilter();
145+
assertFiltering( filter, new File("foo.test"), true);
146+
assertFiltering( filter, new File("foo"), true);
147+
assertFiltering( filter, new File(""), true);
138148
}
139149

140150
}

0 commit comments

Comments
 (0)