Skip to content

Commit eb40d8e

Browse files
author
Gary Gregory
committed
inline some-single use variables.
Formatting nits.
1 parent a463f1e commit eb40d8e

4 files changed

Lines changed: 5 additions & 11 deletions

File tree

src/main/java/org/apache/commons/io/filefilter/AgeFileFilter.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,7 @@ public AgeFileFilter(final long cutoffMillis, final boolean acceptOlder) {
181181
*/
182182
@Override
183183
public boolean accept(final File file) {
184-
final boolean newer = FileUtils.isFileNewer(file, cutoffInstant);
185-
return acceptOlder != newer;
184+
return acceptOlder != FileUtils.isFileNewer(file, cutoffInstant);
186185
}
187186

188187
/**
@@ -198,13 +197,11 @@ public boolean accept(final File file) {
198197
*/
199198
@Override
200199
public FileVisitResult accept(final Path file, final BasicFileAttributes attributes) {
201-
final boolean newer;
202200
try {
203-
newer = PathUtils.isNewer(file, cutoffInstant);
201+
return toFileVisitResult(acceptOlder != PathUtils.isNewer(file, cutoffInstant));
204202
} catch (final IOException e) {
205203
return handle(e);
206204
}
207-
return toFileVisitResult(acceptOlder != newer);
208205
}
209206

210207
/**

src/main/java/org/apache/commons/io/filefilter/MagicNumberFileFilter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,7 @@ public MagicNumberFileFilter(final String magicNumber, final long offset) {
235235
throw new IllegalArgumentException("The offset cannot be negative");
236236
}
237237

238-
this.magicNumbers = magicNumber.getBytes(Charset.defaultCharset()); // explicitly uses the platform default
239-
// charset
238+
this.magicNumbers = magicNumber.getBytes(Charset.defaultCharset()); // explicitly uses the platform default charset
240239
this.byteOffset = offset;
241240
}
242241

src/main/java/org/apache/commons/io/filefilter/NotFileFilter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@ public FileVisitResult accept(final Path file, final BasicFileAttributes attribu
8484
}
8585

8686
private FileVisitResult not(final FileVisitResult accept) {
87-
return accept == FileVisitResult.CONTINUE ? FileVisitResult.TERMINATE
88-
: FileVisitResult.CONTINUE;
87+
return accept == FileVisitResult.CONTINUE ? FileVisitResult.TERMINATE : FileVisitResult.CONTINUE;
8988
}
9089

9190
/**

src/main/java/org/apache/commons/io/filefilter/PathVisitorFileFilter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ public PathVisitorFileFilter(final PathVisitor pathVisitor) {
5050
public boolean accept(final File file) {
5151
try {
5252
final Path path = file.toPath();
53-
return visitFile(path,
54-
file.exists() ? PathUtils.readBasicFileAttributes(path) : null) == FileVisitResult.CONTINUE;
53+
return visitFile(path, file.exists() ? PathUtils.readBasicFileAttributes(path) : null) == FileVisitResult.CONTINUE;
5554
} catch (final IOException e) {
5655
return handle(e) == FileVisitResult.CONTINUE;
5756
}

0 commit comments

Comments
 (0)