Skip to content

Commit ec04894

Browse files
committed
Adding EB/PB/TB per IO-287 and Ron Kuris' patch
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/io/trunk@1201022 13f79535-47bb-0310-9956-ffa450edef68
1 parent 2316361 commit ec04894

2 files changed

Lines changed: 11 additions & 12 deletions

File tree

src/main/java/org/apache/commons/io/FileUtils.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -352,14 +352,13 @@ public static FileOutputStream openOutputStream(File file, boolean append) throw
352352
public static String byteCountToDisplaySize(long size) {
353353
String displaySize;
354354

355-
// if (size / ONE_EB > 0) {
356-
// displaySize = String.valueOf(size / ONE_EB) + " EB";
357-
// } else if (size / ONE_PB > 0) {
358-
// displaySize = String.valueOf(size / ONE_PB) + " PB";
359-
// } else if (size / ONE_TB > 0) {
360-
// displaySize = String.valueOf(size / ONE_TB) + " TB";
361-
// } else
362-
if (size / ONE_GB > 0) {
355+
if (size / ONE_EB > 0) {
356+
displaySize = String.valueOf(size / ONE_EB) + " EB";
357+
} else if (size / ONE_PB > 0) {
358+
displaySize = String.valueOf(size / ONE_PB) + " PB";
359+
} else if (size / ONE_TB > 0) {
360+
displaySize = String.valueOf(size / ONE_TB) + " TB";
361+
} else if (size / ONE_GB > 0) {
363362
displaySize = String.valueOf(size / ONE_GB) + " GB";
364363
} else if (size / ONE_MB > 0) {
365364
displaySize = String.valueOf(size / ONE_MB) + " MB";

src/test/java/org/apache/commons/io/FileUtilsTestCase.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -324,10 +324,10 @@ public void testByteCountToDisplaySize() {
324324
assertEquals(FileUtils.byteCountToDisplaySize(1024 * 1024 * 1024), "1 GB");
325325
assertEquals(FileUtils.byteCountToDisplaySize(1024 * 1024 * 1025), "1 GB");
326326
assertEquals(FileUtils.byteCountToDisplaySize((1024 * 1024 * 1024 * 2) - 1), "1 GB");
327-
// assertEquals(FileUtils.byteCountToDisplaySize(1024L * 1024 * 1024 * 1024), "1 TB");
328-
// assertEquals(FileUtils.byteCountToDisplaySize(1024L * 1024 * 1024 * 1024 * 1024), "1 PB");
329-
// assertEquals(FileUtils.byteCountToDisplaySize(1024L * 1024 * 1024 * 1024 * 1024 * 1024), "1 EB");
330-
// assertEquals(FileUtils.byteCountToDisplaySize(Long.MAX_VALUE), "7 EB");
327+
assertEquals(FileUtils.byteCountToDisplaySize(1024L * 1024 * 1024 * 1024), "1 TB");
328+
assertEquals(FileUtils.byteCountToDisplaySize(1024L * 1024 * 1024 * 1024 * 1024), "1 PB");
329+
assertEquals(FileUtils.byteCountToDisplaySize(1024L * 1024 * 1024 * 1024 * 1024 * 1024), "1 EB");
330+
assertEquals(FileUtils.byteCountToDisplaySize(Long.MAX_VALUE), "7 EB");
331331
// Other MAX_VALUEs
332332
assertEquals(FileUtils.byteCountToDisplaySize(Character.MAX_VALUE), "63 KB");
333333
assertEquals(FileUtils.byteCountToDisplaySize(Short.MAX_VALUE), "31 KB");

0 commit comments

Comments
 (0)