Don't initialize instance variables to default values

garydgregory · garydgregory · commit f47d9346a897 · 2026-03-23T18:33:31.000-07:00
diff --git a/src/main/java/org/apache/commons/io/channels/ByteArraySeekableByteChannel.java b/src/main/java/org/apache/commons/io/channels/ByteArraySeekableByteChannel.java
@@ -86,7 +86,6 @@ public ByteArraySeekableByteChannel() {
 
     private ByteArraySeekableByteChannel(final byte[] data) {
         this.data = data;
-        this.position = 0;
         this.size = data.length;
     }
 
@@ -104,8 +103,6 @@ public ByteArraySeekableByteChannel(final int size) {
             throw new IllegalArgumentException("Size must be non-negative");
         }
         this.data = new byte[size];
-        this.position = 0;
-        this.size = 0;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,6 @@ public ByteArraySeekableByteChannel() {`
`86`	`86`
`87`	`87`	`private ByteArraySeekableByteChannel(final byte[] data) {`
`88`	`88`	`this.data = data;`
`89`		`- this.position = 0;`
`90`	`89`	`this.size = data.length;`
`91`	`90`	`}`
`92`	`91`
`@@ -104,8 +103,6 @@ public ByteArraySeekableByteChannel(final int size) {`
`104`	`103`	`throw new IllegalArgumentException("Size must be non-negative");`
`105`	`104`	`}`
`106`	`105`	`this.data = new byte[size];`
`107`		`- this.position = 0;`
`108`		`- this.size = 0;`
`109`	`106`	`}`
`110`	`107`
`111`	`108`	`/**`