Skip to content

Commit fcca356

Browse files
committed
Remove unnecessary casts.
1 parent c4c86e2 commit fcca356

15 files changed

Lines changed: 77 additions & 77 deletions

src/test/java/org/apache/commons/io/CopyUtilsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ private static File getTestDirectory() {
6262
private static final int FILE_SIZE = 1024 * 4 + 1;
6363

6464

65-
private final byte[] inData = TestUtils.generateTestData((long) FILE_SIZE);
65+
private final byte[] inData = TestUtils.generateTestData(FILE_SIZE);
6666

6767
// ----------------------------------------------------------------
6868
// Tests

src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ public void testFileCleanerDirectory_ForceStrategy() throws Exception {
159159
}
160160
try (final BufferedOutputStream output =
161161
new BufferedOutputStream(new FileOutputStream(testFile))) {
162-
TestUtils.generateTestData(output, (long) 100);
162+
TestUtils.generateTestData(output, 100);
163163
}
164164
assertTrue(testFile.exists());
165165
assertTrue(getTestDirectory().exists());

src/test/java/org/apache/commons/io/FileDeleteStrategyTestCase.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void testDeleteNormal() throws Exception {
5959
}
6060
try (final BufferedOutputStream output =
6161
new BufferedOutputStream(new FileOutputStream(subFile))) {
62-
TestUtils.generateTestData(output, (long) 16);
62+
TestUtils.generateTestData(output, 16);
6363
}
6464

6565
assertTrue(subDir.exists());
@@ -97,7 +97,7 @@ public void testDeleteQuietlyNormal() throws Exception {
9797
}
9898
try (final BufferedOutputStream output =
9999
new BufferedOutputStream(new FileOutputStream(subFile))) {
100-
TestUtils.generateTestData(output, (long) 16);
100+
TestUtils.generateTestData(output, 16);
101101
}
102102

103103
assertTrue(subDir.exists());
@@ -130,7 +130,7 @@ public void testDeleteForce() throws Exception {
130130
}
131131
try (final BufferedOutputStream output =
132132
new BufferedOutputStream(new FileOutputStream(subFile))) {
133-
TestUtils.generateTestData(output, (long) 16);
133+
TestUtils.generateTestData(output, 16);
134134
}
135135

136136
assertTrue(subDir.exists());

src/test/java/org/apache/commons/io/FileUtilsFileNewerTestCase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,15 @@ public void setUp() throws Exception {
6666
}
6767
try (final BufferedOutputStream output1 =
6868
new BufferedOutputStream(new FileOutputStream(m_testFile1))) {
69-
TestUtils.generateTestData(output1, (long) FILE1_SIZE);
69+
TestUtils.generateTestData(output1, FILE1_SIZE);
7070
}
7171
if (!m_testFile2.getParentFile().exists()) {
7272
throw new IOException("Cannot create file " + m_testFile2
7373
+ " as the parent directory does not exist");
7474
}
7575
try (final BufferedOutputStream output =
7676
new BufferedOutputStream(new FileOutputStream(m_testFile2))) {
77-
TestUtils.generateTestData(output, (long) FILE2_SIZE);
77+
TestUtils.generateTestData(output, FILE2_SIZE);
7878
}
7979
}
8080

src/test/java/org/apache/commons/io/FileUtilsTestCase.java

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -124,15 +124,15 @@ public void setUp() throws Exception {
124124
}
125125
try (final BufferedOutputStream output3 =
126126
new BufferedOutputStream(new FileOutputStream(testFile1))) {
127-
TestUtils.generateTestData(output3, (long) testFile1Size);
127+
TestUtils.generateTestData(output3, testFile1Size);
128128
}
129129
if (!testFile2.getParentFile().exists()) {
130130
throw new IOException("Cannot create file " + testFile2
131131
+ " as the parent directory does not exist");
132132
}
133133
try (final BufferedOutputStream output2 =
134134
new BufferedOutputStream(new FileOutputStream(testFile2))) {
135-
TestUtils.generateTestData(output2, (long) testFile2Size);
135+
TestUtils.generateTestData(output2, testFile2Size);
136136
}
137137
FileUtils.deleteDirectory(getTestDirectory());
138138
getTestDirectory().mkdirs();
@@ -142,15 +142,15 @@ public void setUp() throws Exception {
142142
}
143143
try (final BufferedOutputStream output1 =
144144
new BufferedOutputStream(new FileOutputStream(testFile1))) {
145-
TestUtils.generateTestData(output1, (long) testFile1Size);
145+
TestUtils.generateTestData(output1, testFile1Size);
146146
}
147147
if (!testFile2.getParentFile().exists()) {
148148
throw new IOException("Cannot create file " + testFile2
149149
+ " as the parent directory does not exist");
150150
}
151151
try (final BufferedOutputStream output =
152152
new BufferedOutputStream(new FileOutputStream(testFile2))) {
153-
TestUtils.generateTestData(output, (long) testFile2Size);
153+
TestUtils.generateTestData(output, testFile2Size);
154154
}
155155
}
156156

@@ -1012,7 +1012,7 @@ public void testIsFileNewerOlder() throws Exception {
10121012
final BufferedOutputStream output1 =
10131013
new BufferedOutputStream(new FileOutputStream(oldFile));
10141014
try {
1015-
TestUtils.generateTestData(output1, (long) 0);
1015+
TestUtils.generateTestData(output1, 0);
10161016
} finally {
10171017
IOUtils.closeQuietly(output1);
10181018
}
@@ -1030,7 +1030,7 @@ public void testIsFileNewerOlder() throws Exception {
10301030
final BufferedOutputStream output =
10311031
new BufferedOutputStream(new FileOutputStream(reference));
10321032
try {
1033-
TestUtils.generateTestData(output, (long) 0);
1033+
TestUtils.generateTestData(output, 0);
10341034
} finally {
10351035
IOUtils.closeQuietly(output);
10361036
}
@@ -1052,7 +1052,7 @@ public void testIsFileNewerOlder() throws Exception {
10521052
final BufferedOutputStream output =
10531053
new BufferedOutputStream(new FileOutputStream(newFile));
10541054
try {
1055-
TestUtils.generateTestData(output, (long) 0);
1055+
TestUtils.generateTestData(output, 0);
10561056
} finally {
10571057
IOUtils.closeQuietly(output);
10581058
}
@@ -1270,7 +1270,7 @@ public void testCopyDirectoryToDirectory_NonExistingDest() throws Exception {
12701270
final BufferedOutputStream output1 =
12711271
new BufferedOutputStream(new FileOutputStream(testFile1));
12721272
try {
1273-
TestUtils.generateTestData(output1, (long) 1234);
1273+
TestUtils.generateTestData(output1, 1234);
12741274
} finally {
12751275
IOUtils.closeQuietly(output1);
12761276
}
@@ -1281,7 +1281,7 @@ public void testCopyDirectoryToDirectory_NonExistingDest() throws Exception {
12811281
final BufferedOutputStream output =
12821282
new BufferedOutputStream(new FileOutputStream(testFile2));
12831283
try {
1284-
TestUtils.generateTestData(output, (long) 4321);
1284+
TestUtils.generateTestData(output, 4321);
12851285
} finally {
12861286
IOUtils.closeQuietly(output);
12871287
}
@@ -1314,7 +1314,7 @@ public void testCopyDirectoryToNonExistingDest() throws Exception {
13141314
final BufferedOutputStream output1 =
13151315
new BufferedOutputStream(new FileOutputStream(testFile1));
13161316
try {
1317-
TestUtils.generateTestData(output1, (long) 1234);
1317+
TestUtils.generateTestData(output1, 1234);
13181318
} finally {
13191319
IOUtils.closeQuietly(output1);
13201320
}
@@ -1325,7 +1325,7 @@ public void testCopyDirectoryToNonExistingDest() throws Exception {
13251325
final BufferedOutputStream output =
13261326
new BufferedOutputStream(new FileOutputStream(testFile2));
13271327
try {
1328-
TestUtils.generateTestData(output, (long) 4321);
1328+
TestUtils.generateTestData(output, 4321);
13291329
} finally {
13301330
IOUtils.closeQuietly(output);
13311331
}
@@ -1356,7 +1356,7 @@ public void testCopyDirectoryToExistingDest() throws Exception {
13561356
final BufferedOutputStream output1 =
13571357
new BufferedOutputStream(new FileOutputStream(testFile1));
13581358
try {
1359-
TestUtils.generateTestData(output1, (long) 1234);
1359+
TestUtils.generateTestData(output1, 1234);
13601360
} finally {
13611361
IOUtils.closeQuietly(output1);
13621362
}
@@ -1367,7 +1367,7 @@ public void testCopyDirectoryToExistingDest() throws Exception {
13671367
final BufferedOutputStream output =
13681368
new BufferedOutputStream(new FileOutputStream(testFile2));
13691369
try {
1370-
TestUtils.generateTestData(output, (long) 4321);
1370+
TestUtils.generateTestData(output, 4321);
13711371
} finally {
13721372
IOUtils.closeQuietly(output);
13731373
}
@@ -1820,7 +1820,7 @@ public void testListFiles() throws Exception {
18201820
final BufferedOutputStream output =
18211821
new BufferedOutputStream(new FileOutputStream(theFile));
18221822
try {
1823-
TestUtils.generateTestData(output, (long) fileSizes[i]);
1823+
TestUtils.generateTestData(output, fileSizes[i]);
18241824
} finally {
18251825
IOUtils.closeQuietly(output);
18261826
}
@@ -1870,7 +1870,7 @@ public void testListFilesWithDirs() throws IOException {
18701870
final BufferedOutputStream output =
18711871
new BufferedOutputStream(new FileOutputStream(someFile));
18721872
try {
1873-
TestUtils.generateTestData(output, (long) 100);
1873+
TestUtils.generateTestData(output, 100);
18741874
} finally {
18751875
IOUtils.closeQuietly(output);
18761876
}
@@ -1908,7 +1908,7 @@ public void testIterateFiles() throws Exception {
19081908
final BufferedOutputStream output =
19091909
new BufferedOutputStream(new FileOutputStream(theFile));
19101910
try {
1911-
TestUtils.generateTestData(output, (long) fileSizes[i]);
1911+
TestUtils.generateTestData(output, fileSizes[i]);
19121912
} finally {
19131913
IOUtils.closeQuietly(output);
19141914
}
@@ -1955,7 +1955,7 @@ public void testIterateFilesAndDirs() throws IOException {
19551955
final BufferedOutputStream output =
19561956
new BufferedOutputStream(new FileOutputStream(someFile));
19571957
try {
1958-
TestUtils.generateTestData(output, (long) 100);
1958+
TestUtils.generateTestData(output, 100);
19591959
} finally {
19601960
IOUtils.closeQuietly(output);
19611961
}
@@ -2552,7 +2552,7 @@ public void testDeleteQuietlyDir() throws IOException {
25522552
final BufferedOutputStream output =
25532553
new BufferedOutputStream(new FileOutputStream(testFile));
25542554
try {
2555-
TestUtils.generateTestData(output, (long) 0);
2555+
TestUtils.generateTestData(output, 0);
25562556
} finally {
25572557
IOUtils.closeQuietly(output);
25582558
}
@@ -2574,7 +2574,7 @@ public void testDeleteQuietlyFile() throws IOException {
25742574
final BufferedOutputStream output =
25752575
new BufferedOutputStream(new FileOutputStream(testFile));
25762576
try {
2577-
TestUtils.generateTestData(output, (long) 0);
2577+
TestUtils.generateTestData(output, 0);
25782578
} finally {
25792579
IOUtils.closeQuietly(output);
25802580
}
@@ -2688,7 +2688,7 @@ public void testMoveFile_Errors() throws Exception {
26882688
final BufferedOutputStream output1 =
26892689
new BufferedOutputStream(new FileOutputStream(testSourceFile));
26902690
try {
2691-
TestUtils.generateTestData(output1, (long) 0);
2691+
TestUtils.generateTestData(output1, 0);
26922692
} finally {
26932693
IOUtils.closeQuietly(output1);
26942694
}
@@ -2699,7 +2699,7 @@ public void testMoveFile_Errors() throws Exception {
26992699
final BufferedOutputStream output =
27002700
new BufferedOutputStream(new FileOutputStream(testDestFile));
27012701
try {
2702-
TestUtils.generateTestData(output, (long) 0);
2702+
TestUtils.generateTestData(output, 0);
27032703
} finally {
27042704
IOUtils.closeQuietly(output);
27052705
}
@@ -2746,7 +2746,7 @@ public void testMoveFileToDirectory_Errors() throws Exception {
27462746
final BufferedOutputStream output1 =
27472747
new BufferedOutputStream(new FileOutputStream(testFile1));
27482748
try {
2749-
TestUtils.generateTestData(output1, (long) 0);
2749+
TestUtils.generateTestData(output1, 0);
27502750
} finally {
27512751
IOUtils.closeQuietly(output1);
27522752
}
@@ -2757,7 +2757,7 @@ public void testMoveFileToDirectory_Errors() throws Exception {
27572757
final BufferedOutputStream output =
27582758
new BufferedOutputStream(new FileOutputStream(testFile2));
27592759
try {
2760-
TestUtils.generateTestData(output, (long) 0);
2760+
TestUtils.generateTestData(output, 0);
27612761
} finally {
27622762
IOUtils.closeQuietly(output);
27632763
}
@@ -2792,7 +2792,7 @@ public void testMoveDirectory_Rename() throws Exception {
27922792
final BufferedOutputStream output =
27932793
new BufferedOutputStream(new FileOutputStream(testFile));
27942794
try {
2795-
TestUtils.generateTestData(output, (long) 0);
2795+
TestUtils.generateTestData(output, 0);
27962796
} finally {
27972797
IOUtils.closeQuietly(output);
27982798
}
@@ -2834,7 +2834,7 @@ public boolean renameTo(final File dest) {
28342834
final BufferedOutputStream output =
28352835
new BufferedOutputStream(new FileOutputStream(testFile));
28362836
try {
2837-
TestUtils.generateTestData(output, (long) 0);
2837+
TestUtils.generateTestData(output, 0);
28382838
} finally {
28392839
IOUtils.closeQuietly(output);
28402840
}
@@ -2881,7 +2881,7 @@ public void testMoveDirectory_Errors() throws Exception {
28812881
final BufferedOutputStream output =
28822882
new BufferedOutputStream(new FileOutputStream(testFile));
28832883
try {
2884-
TestUtils.generateTestData(output, (long) 0);
2884+
TestUtils.generateTestData(output, 0);
28852885
} finally {
28862886
IOUtils.closeQuietly(output);
28872887
}
@@ -2917,7 +2917,7 @@ public void testMoveDirectoryToDirectory() throws Exception {
29172917
final BufferedOutputStream output =
29182918
new BufferedOutputStream(new FileOutputStream(testFile));
29192919
try {
2920-
TestUtils.generateTestData(output, (long) 0);
2920+
TestUtils.generateTestData(output, 0);
29212921
} finally {
29222922
IOUtils.closeQuietly(output);
29232923
}
@@ -2962,7 +2962,7 @@ public void testMoveDirectoryToDirectory_Errors() throws Exception {
29622962
final BufferedOutputStream output1 =
29632963
new BufferedOutputStream(new FileOutputStream(testFile1));
29642964
try {
2965-
TestUtils.generateTestData(output1, (long) 0);
2965+
TestUtils.generateTestData(output1, 0);
29662966
} finally {
29672967
IOUtils.closeQuietly(output1);
29682968
}
@@ -2973,7 +2973,7 @@ public void testMoveDirectoryToDirectory_Errors() throws Exception {
29732973
final BufferedOutputStream output =
29742974
new BufferedOutputStream(new FileOutputStream(testFile2));
29752975
try {
2976-
TestUtils.generateTestData(output, (long) 0);
2976+
TestUtils.generateTestData(output, 0);
29772977
} finally {
29782978
IOUtils.closeQuietly(output);
29792979
}
@@ -3006,7 +3006,7 @@ public void testMoveToDirectory() throws Exception {
30063006
final BufferedOutputStream output =
30073007
new BufferedOutputStream(new FileOutputStream(testFile));
30083008
try {
3009-
TestUtils.generateTestData(output, (long) 0);
3009+
TestUtils.generateTestData(output, 0);
30103010
} finally {
30113011
IOUtils.closeQuietly(output);
30123012
}

src/test/java/org/apache/commons/io/FilenameUtilsTestCase.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,31 +75,31 @@ public void setUp() throws Exception {
7575
}
7676
try (final BufferedOutputStream output3 =
7777
new BufferedOutputStream(new FileOutputStream(testFile1))) {
78-
TestUtils.generateTestData(output3, (long) testFile1Size);
78+
TestUtils.generateTestData(output3, testFile1Size);
7979
}
8080
if (!testFile2.getParentFile().exists()) {
8181
throw new IOException("Cannot create file " + testFile2
8282
+ " as the parent directory does not exist");
8383
}
8484
try (final BufferedOutputStream output2 =
8585
new BufferedOutputStream(new FileOutputStream(testFile2))) {
86-
TestUtils.generateTestData(output2, (long) testFile2Size);
86+
TestUtils.generateTestData(output2, testFile2Size);
8787
}
8888
if (!testFile1.getParentFile().exists()) {
8989
throw new IOException("Cannot create file " + testFile1
9090
+ " as the parent directory does not exist");
9191
}
9292
try (final BufferedOutputStream output1 =
9393
new BufferedOutputStream(new FileOutputStream(testFile1))) {
94-
TestUtils.generateTestData(output1, (long) testFile1Size);
94+
TestUtils.generateTestData(output1, testFile1Size);
9595
}
9696
if (!testFile2.getParentFile().exists()) {
9797
throw new IOException("Cannot create file " + testFile2
9898
+ " as the parent directory does not exist");
9999
}
100100
try (final BufferedOutputStream output =
101101
new BufferedOutputStream(new FileOutputStream(testFile2))) {
102-
TestUtils.generateTestData(output, (long) testFile2Size);
102+
TestUtils.generateTestData(output, testFile2Size);
103103
}
104104
}
105105

src/test/java/org/apache/commons/io/IOUtilsCopyTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ private static File getTestDirectory() {
6565
private static final int FILE_SIZE = 1024 * 4 + 1;
6666

6767

68-
private final byte[] inData = TestUtils.generateTestData((long) FILE_SIZE);
68+
private final byte[] inData = TestUtils.generateTestData(FILE_SIZE);
6969

7070
//-----------------------------------------------------------------------
7171
@SuppressWarnings("resource") // 'in' is deliberately not closed

src/test/java/org/apache/commons/io/IOUtilsTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public void setUp() {
120120
final BufferedOutputStream output =
121121
new BufferedOutputStream(new FileOutputStream(m_testFile));
122122
try {
123-
TestUtils.generateTestData(output, (long) FILE_SIZE);
123+
TestUtils.generateTestData(output, FILE_SIZE);
124124
} finally {
125125
IOUtils.closeQuietly(output);
126126
}

src/test/java/org/apache/commons/io/IOUtilsWriteTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ private static File getTestDirectory() {
5151

5252
private static final int FILE_SIZE = 1024 * 4 + 1;
5353

54-
private final byte[] inData = TestUtils.generateTestData((long) FILE_SIZE);
54+
private final byte[] inData = TestUtils.generateTestData(FILE_SIZE);
5555

5656
// ----------------------------------------------------------------
5757
// Tests

0 commit comments

Comments
 (0)