Use compact array declaration

garydgregory · garydgregory · commit 8f7d4d6bc5c1 · 2025-06-13T15:02:36.000-04:00
Use final
diff --git a/src/main/java/org/apache/commons/net/nntp/NewsgroupInfo.java b/src/main/java/org/apache/commons/net/nntp/NewsgroupInfo.java
@@ -46,7 +46,7 @@ public final class NewsgroupInfo {
     /**
      * The empty array of this type.
      */
-    static final NewsgroupInfo[] EMPTY_ARRAY = new NewsgroupInfo[0];
+    static final NewsgroupInfo[] EMPTY_ARRAY = {};
 
     private String newsgroup;
     private long estimatedArticleCount;
diff --git a/src/main/java/org/apache/commons/net/tftp/TFTPRequestPacket.java b/src/main/java/org/apache/commons/net/tftp/TFTPRequestPacket.java
@@ -208,7 +208,7 @@ public final DatagramPacket newDatagram() {
         modeLength = modeBytes[mode].length;
 
         int optionsLength = 0;
-        for (Map.Entry<String, String> entry : options.entrySet()) {
+        for (final Map.Entry<String, String> entry : options.entrySet()) {
             optionsLength += entry.getKey().length() + 1 + entry.getValue().length() + 1;
         }
         data = new byte[fileLength + modeLength + 3 + optionsLength];
@@ -257,9 +257,9 @@ final DatagramPacket newDatagram(final DatagramPacket datagram, final byte[] dat
         return datagram;
     }
 
-    private void handleOptions(byte[] data, int fileLength, int modeLength) {
+    private void handleOptions(final byte[] data, final int fileLength, final int modeLength) {
         int index = fileLength + modeLength + 2;
-        for (Map.Entry<String, String> entry : options.entrySet()) {
+        for (final Map.Entry<String, String> entry : options.entrySet()) {
             data[index] = 0;
             final String key = entry.getKey();
             final String value = entry.getValue();
diff --git a/src/test/java/org/apache/commons/net/tftp/TFTPRequestPacketTest.java b/src/test/java/org/apache/commons/net/tftp/TFTPRequestPacketTest.java
@@ -83,7 +83,7 @@ private static DatagramPacket getDatagramPacket() throws UnknownHostException {
             byteStream.write(0);
             byteStream.write("1024".getBytes(StandardCharsets.US_ASCII));
             byteStream.write(0);
-        } catch (IOException e) {
+        } catch (final IOException e) {
             throw new RuntimeException("Error creating TFTP request packet", e);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ private static DatagramPacket getDatagramPacket() throws UnknownHostException {`
`83`	`83`	`byteStream.write(0);`
`84`	`84`	`byteStream.write("1024".getBytes(StandardCharsets.US_ASCII));`
`85`	`85`	`byteStream.write(0);`
`86`		`- } catch (IOException e) {`
	`86`	`+ } catch (final IOException e) {`
`87`	`87`	`throw new RuntimeException("Error creating TFTP request packet", e);`
`88`	`88`	`}`
`89`	`89`