From 99409ac1450dfeb1210d28ae80fb97eab6251406 Mon Sep 17 00:00:00 2001 From: Amey Jadiye Date: Sat, 30 Sep 2017 14:57:48 +0530 Subject: [PATCH 1/2] adding validation for pair --- .../java/org/apache/commons/text/RandomStringGenerator.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/text/RandomStringGenerator.java b/src/main/java/org/apache/commons/text/RandomStringGenerator.java index d8892fc557..02af0d43b8 100644 --- a/src/main/java/org/apache/commons/text/RandomStringGenerator.java +++ b/src/main/java/org/apache/commons/text/RandomStringGenerator.java @@ -341,8 +341,10 @@ public Builder withinRange(final int minimumCodePoint, final int maximumCodePoin * @return {@code this}, to allow method chaining. */ public Builder withinRange(final char[] ... pairs) { - characterList = new ArrayList<>(); + characterList = new ArrayList(); for (final char[] pair : pairs) { + Validate.isTrue(pair.length == 2, + "Each pair must contain minimum and maximum code point"); final int minimumCodePoint = pair[0]; final int maximumCodePoint = pair[1]; Validate.isTrue(minimumCodePoint <= maximumCodePoint, From 0fd044f4b88bfb5055c53dc84463831a0c42972d Mon Sep 17 00:00:00 2001 From: Amey Jadiye Date: Sat, 30 Sep 2017 15:00:18 +0530 Subject: [PATCH 2/2] added amey's mail id --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index 1db78a5dbb..d9ea86ebb6 100644 --- a/pom.xml +++ b/pom.xml @@ -314,6 +314,7 @@ Amey Jadiye + ameyjadiye@gmail.com Arun Vinud S S