From a2e76ee893cf5d2ac5b5212e9b17de5ff9e7ec8e Mon Sep 17 00:00:00 2001 From: TheRealHaui Date: Fri, 21 Nov 2025 22:53:41 +0100 Subject: [PATCH 1/3] Added new test for CharSequenceTranslator#with. --- .../translate/CharSequenceTranslatorTest.java | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 src/test/java/org/apache/commons/text/translate/CharSequenceTranslatorTest.java diff --git a/src/test/java/org/apache/commons/text/translate/CharSequenceTranslatorTest.java b/src/test/java/org/apache/commons/text/translate/CharSequenceTranslatorTest.java new file mode 100644 index 0000000000..21b2cbc0f6 --- /dev/null +++ b/src/test/java/org/apache/commons/text/translate/CharSequenceTranslatorTest.java @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + package org.apache.commons.text.translate; + +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; + +import java.io.IOException; +import java.io.Writer; + +import org.junit.jupiter.api.Test; + + +class CharSequenceTranslatorTest { + + //Used to count translate invocations + private int translateInvocationCounter; + + @Test + void testWith() throws IOException { + CharSequenceTranslator charSequenceTranslatorOne = new TestCharSequenceTranslator(); + CharSequenceTranslator charSequenceTranslatorTwo = new TestCharSequenceTranslator(); + CharSequenceTranslator charSequenceTranslatorThree = new TestCharSequenceTranslator(); + + CharSequenceTranslator aggregatedTranslator = charSequenceTranslatorOne.with(charSequenceTranslatorTwo, charSequenceTranslatorThree); + + aggregatedTranslator.translate("", 0, null); + + assertTrue(aggregatedTranslator instanceof AggregateTranslator); + assertEquals(3, translateInvocationCounter); + + } + + + private final class TestCharSequenceTranslator extends CharSequenceTranslator { + @Override + public int translate(final CharSequence input, final int index, final Writer writer) { + translateInvocationCounter++; + return 0; + } + + } + +} From cd68a75b519c8ee17334e8b0877eb21a7d0f6d26 Mon Sep 17 00:00:00 2001 From: TheRealHaui Date: Fri, 21 Nov 2025 23:03:03 +0100 Subject: [PATCH 2/3] Fixed typo --- src/changes/changes.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index ef5abe56ee..e9c6b331a8 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -49,7 +49,7 @@ The type attribute can be add,update,fix,remove. Fix exception message typo in XmlStringLookup.XmlStringLookup(Map, Path...). Inserting at the end of a TextStringBuilder throws a StringIndexOutOfBoundsException. - Fix TextStringBuilderTest.testAppendToCharBuffer() to use proper argument type #724. + Fix TextStringBuilderTest.testAppendToCharBuffer() to use proper argument type #724. Add experimental CycloneDX VEX file #683. Add Damerau-Levenshtein distance #687. From 04e2539b9a953fef505d5e8cbae5a40cbe51f339 Mon Sep 17 00:00:00 2001 From: Gary Gregory Date: Fri, 21 Nov 2025 17:19:13 -0500 Subject: [PATCH 3/3] Reduce whitespace --- .../commons/text/translate/CharSequenceTranslatorTest.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/test/java/org/apache/commons/text/translate/CharSequenceTranslatorTest.java b/src/test/java/org/apache/commons/text/translate/CharSequenceTranslatorTest.java index 21b2cbc0f6..8bc38cae71 100644 --- a/src/test/java/org/apache/commons/text/translate/CharSequenceTranslatorTest.java +++ b/src/test/java/org/apache/commons/text/translate/CharSequenceTranslatorTest.java @@ -35,17 +35,12 @@ void testWith() throws IOException { CharSequenceTranslator charSequenceTranslatorOne = new TestCharSequenceTranslator(); CharSequenceTranslator charSequenceTranslatorTwo = new TestCharSequenceTranslator(); CharSequenceTranslator charSequenceTranslatorThree = new TestCharSequenceTranslator(); - CharSequenceTranslator aggregatedTranslator = charSequenceTranslatorOne.with(charSequenceTranslatorTwo, charSequenceTranslatorThree); - aggregatedTranslator.translate("", 0, null); - assertTrue(aggregatedTranslator instanceof AggregateTranslator); assertEquals(3, translateInvocationCounter); - } - private final class TestCharSequenceTranslator extends CharSequenceTranslator { @Override public int translate(final CharSequence input, final int index, final Writer writer) {