Skip to content

Commit 298527f

Browse files
committed
Use final.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1539804 13f79535-47bb-0310-9956-ffa450edef68
1 parent e7f9daf commit 298527f

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,12 @@ public static PhonemeBuilder empty(final Languages.LanguageSet languages) {
7171

7272
private final Set<Rule.Phoneme> phonemes;
7373

74-
private PhonemeBuilder(Rule.Phoneme phoneme) {
74+
private PhonemeBuilder(final Rule.Phoneme phoneme) {
7575
this.phonemes = new LinkedHashSet<Rule.Phoneme>();
7676
this.phonemes.add(phoneme);
7777
}
7878

79-
private PhonemeBuilder(Set<Rule.Phoneme> phonemes) {
79+
private PhonemeBuilder(final Set<Rule.Phoneme> phonemes) {
8080
this.phonemes = phonemes;
8181
}
8282

@@ -202,9 +202,9 @@ public PhonemeBuilder getPhonemeBuilder() {
202202
public RulesApplication invoke() {
203203
this.found = false;
204204
int patternLength = 1;
205-
List<Rule> rules = this.finalRules.get(input.subSequence(i, i+patternLength));
205+
final List<Rule> rules = this.finalRules.get(input.subSequence(i, i+patternLength));
206206
if (rules != null) {
207-
for (Rule rule : rules) {
207+
for (final Rule rule : rules) {
208208
final String pattern = rule.getPattern();
209209
patternLength = pattern.length();
210210
if (rule.patternAndContextMatches(this.input, this.i)) {

src/main/java/org/apache/commons/codec/language/bm/Rule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ public String toString() {
396396
return sb.toString();
397397
}
398398
};
399-
String patternKey = r.pattern.substring(0,1);
399+
final String patternKey = r.pattern.substring(0,1);
400400
List<Rule> rules = lines.get(patternKey);
401401
if (rules == null) {
402402
rules = new ArrayList<Rule>();

src/test/java/org/apache/commons/codec/binary/Base64Test.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ public void testBase64() {
114114
@Test
115115
public void testDecodeWithInnerPad() {
116116
final String content = "SGVsbG8gV29ybGQ=SGVsbG8gV29ybGQ=";
117-
byte[] result = Base64.decodeBase64(content);
118-
byte[] shouldBe = StringUtils.getBytesUtf8("Hello World");
117+
final byte[] result = Base64.decodeBase64(content);
118+
final byte[] shouldBe = StringUtils.getBytesUtf8("Hello World");
119119
assertTrue("decode should halt at pad (=)", Arrays.equals(result, shouldBe));
120120
}
121121

src/test/java/org/apache/commons/codec/language/bm/PhoneticEnginePerformanceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public class PhoneticEnginePerformanceTest {
9999

100100
@Test
101101
public void test() {
102-
PhoneticEngine engine = new PhoneticEngine(NameType.GENERIC, RuleType.APPROX, true);
102+
final PhoneticEngine engine = new PhoneticEngine(NameType.GENERIC, RuleType.APPROX, true);
103103
final String input = "Angelo";
104104
final long startMillis = System.currentTimeMillis();
105105
for (int i = 0; i < LOOP; i++) {

0 commit comments

Comments
 (0)