Skip to content

Commit c4e813f

Browse files
committed
Add elements of a collections without a loop.
1 parent fe8b24c commit c4e813f

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

src/main/java/org/apache/commons/codec/language/bm/Languages.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,14 @@ public LanguageSet restrictTo(final LanguageSet other) {
123123
} else if (other == ANY_LANGUAGE) {
124124
return this;
125125
} else {
126-
final SomeLanguages sl = (SomeLanguages) other;
127-
final Set<String> ls = new HashSet<>(Math.min(languages.size(), sl.languages.size()));
126+
final SomeLanguages someLanguages = (SomeLanguages) other;
127+
final Set<String> set = new HashSet<>(Math.min(languages.size(), someLanguages.languages.size()));
128128
for (final String lang : languages) {
129-
if (sl.languages.contains(lang)) {
130-
ls.add(lang);
129+
if (someLanguages.languages.contains(lang)) {
130+
set.add(lang);
131131
}
132132
}
133-
return from(ls);
133+
return from(set);
134134
}
135135
}
136136

@@ -141,12 +141,10 @@ public LanguageSet merge(final LanguageSet other) {
141141
} else if (other == ANY_LANGUAGE) {
142142
return other;
143143
} else {
144-
final SomeLanguages sl = (SomeLanguages) other;
145-
final Set<String> ls = new HashSet<>(languages);
146-
for (final String lang : sl.languages) {
147-
ls.add(lang);
148-
}
149-
return from(ls);
144+
final SomeLanguages someLanguages = (SomeLanguages) other;
145+
final Set<String> set = new HashSet<>(languages);
146+
set.addAll(someLanguages.languages);
147+
return from(set);
150148
}
151149
}
152150

0 commit comments

Comments
 (0)