Dialog: Don't try to place the dialog next to itself on destroy. Fixes #8613 - Destroying a dialog removes the original element from the DOM.

scottgonzalez · scottgonzalez · commit 4ab4684cfc36 · 2012-10-01T15:34:44.000-04:00
diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js
@@ -216,7 +216,8 @@ $.widget("ui.dialog", {
 		}
 
 		next = oldPosition.parent.children().eq( oldPosition.index );
-		if ( next.length ) {
+		// Don't try to place the dialog next to itself (#8613)
+		if ( next.length && next[ 0 ] !== this.element[ 0 ] ) {
 			next.before( this.element );
 		} else {
 			oldPosition.parent.append( this.element );

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,8 @@ $.widget("ui.dialog", {`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`next = oldPosition.parent.children().eq( oldPosition.index );`
`219`		`- if ( next.length ) {`
	`219`	`+ // Don't try to place the dialog next to itself (#8613)`
	`220`	`+ if ( next.length && next[ 0 ] !== this.element[ 0 ] ) {`
`220`	`221`	`next.before( this.element );`
`221`	`222`	`} else {`
`222`	`223`	`oldPosition.parent.append( this.element );`