Fixes commons-app#4682 - Removed read_phone_state_permission

ashishkumar468 · ashishkumar468 · commit 55a56bc5afdb · 2021-12-08T16:01:48.000+05:30
diff --git a/app/build.gradle b/app/build.gradle
@@ -41,6 +41,7 @@ dependencies {
     implementation 'com.mapbox.mapboxsdk:mapbox-android-sdk:9.1.0'
     implementation 'com.mapbox.mapboxsdk:mapbox-android-plugin-localization-v8:0.11.0'
     implementation 'com.mapbox.mapboxsdk:mapbox-android-plugin-scalebar-v9:0.4.0'
+    implementation 'com.mapbox.mapboxsdk:mapbox-android-telemetry:6.1.0'
     implementation 'com.github.deano2390:MaterialShowcaseView:1.2.0'
     implementation 'com.dinuscxj:circleprogressbar:1.1.1'
     implementation 'com.karumi:dexter:5.0.0'
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -17,7 +17,6 @@
     <uses-permission android:name="com.google.android.apps.photos.permission.GOOGLE_PHOTOS" />
     <uses-permission android:name="android.permission.SET_WALLPAPER"/>
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
-    <uses-permission android:name="android.permission.READ_PHONE_STATE"/>
 
 
 
diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java b/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java
@@ -143,31 +143,15 @@ public void setSelectedItemId(int id) {
 
     private void setUpPager() {
         tabLayout.setOnNavigationItemSelectedListener(item -> {
-            if (VERSION.SDK_INT >= VERSION_CODES.M) {
-                if (item.getTitle().equals(getString(R.string.nearby_fragment))
-                    && checkSelfPermission(permission.READ_PHONE_STATE)
-                    != PackageManager.PERMISSION_GRANTED) {
-                    requestPhoneStatePermission(() -> {
-                        tabLayout.setSelectedItemId(NavTab.NEARBY.code());
-                    });
-                    return false;
-                }
-            }
             if (!item.getTitle().equals(getString(R.string.more))) {
                 // do not change title for more fragment
                 setTitle(item.getTitle());
             }
-            Fragment fragment = NavTab.of(item.getOrder()).newInstance();
+            final Fragment fragment = NavTab.of(item.getOrder()).newInstance();
             return loadFragment(fragment, true);
         });
     }
 
-    private void requestPhoneStatePermission(final Runnable runnable) {
-        PermissionUtils.checkPermissionsAndPerformAction(this,
-            android.Manifest.permission.READ_PHONE_STATE, (Runnable) runnable::run, (Runnable) () -> {
-            }, R.string.need_permission, R.string.read_phone_state_permission_message);
-    }
-
     private void setUpLoggedOutPager() {
         loadFragment(ExploreFragment.newInstance(),false);
         tabLayout.setOnNavigationItemSelectedListener(item -> {
