Skip to content

Commit 01f6c99

Browse files
ashishkumar468maskaravivek
authored andcommitted
* Addded null check on bookmark before operating on it
1 parent fbf7cd5 commit 01f6c99

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesDao.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,14 @@
66
import android.database.sqlite.SQLiteDatabase;
77
import android.os.RemoteException;
88
import android.support.annotation.NonNull;
9-
9+
import fr.free.nrw.commons.bookmarks.Bookmark;
1010
import java.util.ArrayList;
1111
import java.util.List;
12-
1312
import javax.inject.Inject;
1413
import javax.inject.Named;
1514
import javax.inject.Provider;
1615
import javax.inject.Singleton;
1716

18-
import fr.free.nrw.commons.bookmarks.Bookmark;
19-
2017
import static fr.free.nrw.commons.bookmarks.pictures.BookmarkPicturesContentProvider.BASE_URI;
2118

2219
@Singleton
@@ -121,6 +118,10 @@ private void deleteBookmark(Bookmark bookmark) {
121118
* @return boolean : is bookmark in database ?
122119
*/
123120
public boolean findBookmark(Bookmark bookmark) {
121+
if (bookmark == null) {//Avoiding NPE's
122+
return false;
123+
}
124+
124125
Cursor cursor = null;
125126
ContentProviderClient db = clientProvider.get();
126127
try {

0 commit comments

Comments
 (0)