Disabled Share button in achievements until achievements are loaded (commons-app#2356)

* item hidden until loading

* Fixed Issue commons-app#2353

Author: vanshikaarora

app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java

@@ -101,6 +101,7 @@ public class AchievementsActivity extends NavigationBaseActivity {
     SessionManager sessionManager;
     @Inject
     MediaWikiApi mediaWikiApi;
+    MenuItem item;
 
     private CompositeDisposable compositeDisposable = new CompositeDisposable();
 
@@ -133,6 +134,7 @@ protected void onCreate(Bundle savedInstanceState) {
 
         setSupportActionBar(toolbar);
         progressBar.setVisibility(View.VISIBLE);
+
         hideLayouts();
         setAchievements();
         initDrawer();
@@ -151,6 +153,8 @@ public void showInfoDialog(){
     public boolean onCreateOptionsMenu(Menu menu) {
         // Inflate the menu; this adds items to the action bar if it is present.
         getMenuInflater().inflate(R.menu.menu_about, menu);
+        item=menu.getItem(0);
+        item.setVisible(false);
         return true;
     }
 
@@ -357,6 +361,7 @@ private void hideProgressBar(Achievements achievements) {
             setUploadProgress(achievements.getImagesUploaded());
             setImageRevertPercentage(achievements.getNotRevertPercentage());
             progressBar.setVisibility(View.GONE);
+            item.setVisible(true);
             layoutImageReverts.setVisibility(View.VISIBLE);
             layoutImageUploaded.setVisibility(View.VISIBLE);
             layoutImageUsedByWiki.setVisibility(View.VISIBLE);