commons-app#3843 Unit Test DepictedItem - add tests (commons-app#3844)

Author: macgills

app/src/main/java/fr/free/nrw/commons/upload/structure/depictions/DepictedItem.kt

@@ -36,7 +36,7 @@ data class DepictedItem constructor(
         place.longDescription
     )
 
-    constructor(entity: Entities.Entity, name: String, description: String) : this(
+    private constructor(entity: Entities.Entity, name: String, description: String) : this(
         name,
         description,
         entity[IMAGE].primaryImageValue?.let {
@@ -69,7 +69,7 @@ private fun List<Statement_partial>?.toIds(): List<String> {
 }
 
 private val List<Statement_partial>?.primaryImageValue: DataValue.ValueString?
-    get() = this?.first()?.mainSnak?.dataValue as? DataValue.ValueString
+    get() = this?.firstOrNull()?.mainSnak?.dataValue as? DataValue.ValueString
 
 operator fun Entities.Entity.get(property: WikidataProperties) =
     statements?.get(property.propertyName)

app/src/test/kotlin/ModelFunctions.kt

@@ -1,5 +1,12 @@
+import com.nhaarman.mockitokotlin2.mock
+import com.nhaarman.mockitokotlin2.whenever
 import fr.free.nrw.commons.category.CategoryItem
+import fr.free.nrw.commons.location.LatLng
+import fr.free.nrw.commons.nearby.Label
+import fr.free.nrw.commons.nearby.Place
+import fr.free.nrw.commons.nearby.Sitelinks
 import fr.free.nrw.commons.upload.structure.depictions.DepictedItem
+import org.wikipedia.wikidata.*
 
 fun depictedItem(
     name: String = "label",
@@ -21,3 +28,59 @@ fun depictedItem(
 
 fun categoryItem(name: String = "name", selected: Boolean = false) =
     CategoryItem(name, selected)
+
+fun place(
+    name: String = "name",
+    label: Label? = null,
+    longDescription: String = "longDescription",
+    latLng: LatLng? = null,
+    category: String = "category",
+    siteLinks: Sitelinks? = null,
+    pic: String = "pic",
+    destroyed: String = "destroyed"
+): Place {
+    return Place(name, label, longDescription, latLng, category, siteLinks, pic, destroyed)
+}
+
+fun entityId(wikiBaseEntityValue: WikiBaseEntityValue = wikiBaseEntityValue()) =
+    DataValue.EntityId(wikiBaseEntityValue)
+
+fun wikiBaseEntityValue(
+    entityType: String = "type",
+    id: String = "id",
+    numericId: Long = 0
+) = WikiBaseEntityValue(entityType, id, numericId)
+
+fun statement(
+    mainSnak: Snak_partial = snak(),
+    rank: String = "rank",
+    type: String = "type"
+) = Statement_partial(mainSnak, type, rank)
+
+fun snak(
+    snakType: String = "type",
+    property: String = "property",
+    dataValue: DataValue = valueString("")
+) = Snak_partial(snakType, property, dataValue)
+
+fun valueString(value: String) = DataValue.ValueString(value)
+
+fun entity(
+    labels: Map<String, String> = emptyMap(),
+    descriptions: Map<String, String> = emptyMap(),
+    statements: Map<String, List<Statement_partial>>? = emptyMap(),
+    id: String = "id"
+) = mock<Entities.Entity>().apply {
+    val mockedLabels = labels.mockLabels()
+    whenever(labels()).thenReturn(mockedLabels)
+    val mockedDescriptions = descriptions.mockLabels()
+    whenever(descriptions()).thenReturn(mockedDescriptions)
+    whenever(this.statements).thenReturn(statements)
+    whenever(id()).thenReturn(id)
+}
+
+private fun Map<String, String>.mockLabels(): Map<String, Entities.Label> {
+    return mapValues { entry ->
+        mock<Entities.Label>().also { whenever(it.value()).thenReturn(entry.value) }
+    }
+}