Fix commons-app#2791: NPE when nominating for deletion and leaving screen (commons-app#2792)

Author: ashishkumar468

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

@@ -2,8 +2,6 @@
 
 import android.annotation.SuppressLint;
 import android.app.AlertDialog;
-import android.content.ClipData;
-import android.content.ClipboardManager;
 import android.content.Intent;
 import android.database.DataSetObserver;
 import android.net.Uri;
@@ -24,15 +22,6 @@
 import android.widget.Spinner;
 import android.widget.TextView;
 import android.widget.Toast;
-
-import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Date;
-import java.util.Locale;
-
-import javax.inject.Inject;
-import javax.inject.Provider;
-
 import butterknife.BindView;
 import butterknife.ButterKnife;
 import butterknife.OnClick;
@@ -56,9 +45,14 @@
 import io.reactivex.Single;
 import io.reactivex.android.schedulers.AndroidSchedulers;
 import io.reactivex.schedulers.Schedulers;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.Locale;
+import javax.inject.Inject;
+import javax.inject.Provider;
 import timber.log.Timber;
 
-import static android.content.Context.CLIPBOARD_SERVICE;
 import static android.view.View.GONE;
 import static android.view.View.VISIBLE;
 import static android.widget.Toast.LENGTH_SHORT;
@@ -71,7 +65,7 @@ public class MediaDetailFragment extends CommonsDaggerSupportFragment {
     private int index;
     private Locale locale;
     private boolean isDeleted = false;
-
+    private DeleteTask deleteTask;
 
     public static MediaDetailFragment forMedia(int index, boolean editable, boolean isCategoryImage) {
         MediaDetailFragment mf = new MediaDetailFragment();
@@ -336,6 +330,11 @@ public void onDestroyView() {
             detailProvider.unregisterDataSetObserver(dataObserver);
             dataObserver = null;
         }
+
+        if (deleteTask != null) {
+            deleteTask.cancel(true);
+            deleteTask = null;
+        }
         super.onDestroyView();
     }
 
@@ -424,10 +423,12 @@ private void onDeleteClicked(Spinner spinner) {
                 .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
                 .subscribe(s -> {
-                    DeleteTask deleteTask = new DeleteTask(getActivity(), media, reason);
-                    deleteTask.execute();
-                    isDeleted = true;
-                    enableDeleteButton(false);
+                    if (getActivity() != null) {
+                        deleteTask = new DeleteTask(getActivity(), media, reason);
+                        deleteTask.execute();
+                        isDeleted = true;
+                        enableDeleteButton(false);
+                    }
                 });
     }