Fixes commons-app#3380 - "Nearby Place found" despite already Nearby upload (commons-app#4408)

* fix issue with "nearby place found" pop up on nearby upload

* added javadoc

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>

Author: Pratham2305

app/src/main/java/fr/free/nrw/commons/upload/UploadItem.java

@@ -18,7 +18,7 @@ public class UploadItem {
   private final String mimeType;
   private ImageCoordinates gpsCoords;
   private List<UploadMediaDetail> uploadMediaDetails;
-  private final Place place;
+  private Place place;
   private final long createdTimestamp;
   private final String createdTimestampSource;
   private final BehaviorSubject<Integer> imageQuality;
@@ -70,6 +70,14 @@ public void setImageQuality(final int imageQuality) {
     this.imageQuality.onNext(imageQuality);
   }
 
+  /**
+   * Sets the corresponding place to the uploadItem
+   * @param place geolocated Wikidata item
+   */
+  public void setPlace(Place place) {
+    this.place = place;
+  }
+
   public Place getPlace() {
     return place;
   }

app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaPresenter.java

@@ -92,7 +92,7 @@ public void receiveImage(UploadableFile uploadableFile, Place place) {
                           gpsCoords != null && gpsCoords.getImageCoordsExists();
                         view.showMapWithImageCoordinates(hasImageCoordinates);
                         view.showProgress(false);
-                        if (hasImageCoordinates) {
+                        if (hasImageCoordinates && place == null) {
                             checkNearbyPlaces(uploadItem);
                         }
                     },
@@ -194,6 +194,9 @@ public void onUserConfirmedUploadIsOfPlace(Place place, int uploadItemPosition)
     final List<UploadMediaDetail> uploadMediaDetails = repository.getUploads()
         .get(uploadItemPosition)
         .getUploadMediaDetails();
+    UploadItem uploadItem = repository.getUploads()
+        .get(uploadItemPosition);
+    uploadItem.setPlace(place);
     uploadMediaDetails.set(0, new UploadMediaDetail(place));
     view.updateMediaDetails(uploadMediaDetails);
   }