commons-app#3763 IllegalArgumentException at fetchImagesForDepictedItem - pass entityId in (commons-app#3764)

Author: macgills

app/src/main/java/fr/free/nrw/commons/depictions/Media/DepictedImagesContract.java

@@ -90,8 +90,9 @@ interface UserActionListener extends BasePresenter<View> {
 
         /**
          * Fetches more images for the item and adds it to the grid view adapter
+         * @param entityId
          */
-        void fetchMoreImages();
+        void fetchMoreImages(String entityId);
 
         /**
          * fetch captions for the image using filename and replace title of on the image thumbnail(if captions are available)

app/src/main/java/fr/free/nrw/commons/depictions/Media/DepictedImagesFragment.java

@@ -136,7 +136,7 @@ public void onScroll(AbsListView view, int firstVisibleItem, int visibleItemCoun
                     if (!NetworkUtils.isInternetConnectionEstablished(getContext())) {
                         handleNoInternet();
                     } else {
-                        presenter.fetchMoreImages();
+                        presenter.fetchMoreImages(entityId);
                     }
                 }
                 if (isLastPage) {

app/src/main/java/fr/free/nrw/commons/depictions/Media/DepictedImagesPresenter.java

@@ -39,7 +39,6 @@ public class DepictedImagesPresenter implements DepictedImagesContract.UserActio
      * Wikibase enitityId for the depicted Item
      * Ex: Q9394
      */
-    private String entityId = null;
     private List<Media> queryList = new ArrayList<>();
 
     @Inject
@@ -79,10 +78,11 @@ public void initList(String entityId) {
 
     /**
      * Fetches more images for the item and adds it to the grid view adapter
+     * @param entityId
      */
     @SuppressLint("CheckResult")
     @Override
-    public void fetchMoreImages() {
+    public void fetchMoreImages(String entityId) {
         view.progressBarVisible(true);
         compositeDisposable.add(depictsClient.fetchImagesForDepictedItem(entityId, queryList.size())
                 .subscribeOn(ioScheduler)