Merge pull request mudbugmedia#41 from mudbugmedia/refactor-tests

Refactor tests

Author: michael-misshore

spec/fixtures/files/config/mutliple-css-paths.yml

@@ -0,0 +1,14 @@
+defaults: &defaults
+  base_url: http://0.0.0.0:9292
+  css_paths:
+    - /test.css
+    - /test2.css
+  routes:
+    - /
+    - /new_route
+
+development:
+  <<: *defaults
+
+test:
+  <<: *defaults

spec/fixtures/files/config/no-paths-specified.yml

@@ -0,0 +1,11 @@
+defaults: &defaults
+  base_url: http://0.0.0.0:9292
+  manifest_name: application
+  routes:
+    - /
+
+development:
+  <<: *defaults
+
+test:
+  <<: *defaults

spec/fixtures/files/config/paths-and-routes-not-same-length.yml

@@ -0,0 +1,15 @@
+defaults: &defaults
+  base_url: http://0.0.0.0:9292
+  css_paths:
+    - /test.css
+    - /test2.css
+  routes:
+    - /
+    - /new_route
+    - /newer_route
+
+development:
+  <<: *defaults
+
+test:
+  <<: *defaults

spec/fixtures/files/config/paths-both-specified.yml

@@ -0,0 +1,15 @@
+defaults: &defaults
+  base_url: http://0.0.0.0:9292
+  css_path: /test.css
+  css_paths:
+    - /test.css
+    - /test2.css
+  routes:
+    - /
+    - /new_route
+
+development:
+  <<: *defaults
+
+test:
+  <<: *defaults

spec/fixtures/files/config/single-css-path.yml

@@ -0,0 +1,11 @@
+defaults: &defaults
+  base_url: http://0.0.0.0:9292
+  css_path: /test.css
+  routes:
+    - /
+
+development:
+  <<: *defaults
+
+test:
+  <<: *defaults

spec/lib/critical_path_css/css_fetcher_spec.rb

@@ -1,12 +1,14 @@
 require 'spec_helper'
 
 RSpec.describe 'CssFetcher' do
-  let(:subject) { CriticalPathCss::CssFetcher.new(config) }
+  subject { CriticalPathCss::CssFetcher.new(config) }
+
+  let(:base_url) { 'http://0.0.0.0:9292' }
   let(:response) { ['foo','', OpenStruct.new(exitstatus: 0)] }
-  let(:routes) { ['/', '/new_route'] }
+  let(:routes)   { ['/', '/new_route'] }
   let(:config) do
     OpenStruct.new(
-      base_url: 'http://0.0.0.0:9292',
+      base_url: base_url,
       css_path: css_path,
       css_paths: css_paths,
       penthouse_options: {},
@@ -22,6 +24,7 @@
       it 'generates css for the single route' do
         expect(Open3).to receive(:capture3) do |arg1, arg2, arg3|
           options = JSON.parse(arg3)
+
           expect(options['css']).to eq '/test.css'
         end.once.and_return(response)
 
@@ -38,8 +41,10 @@
       it 'generates css for each route from the same file' do
         expect(Open3).to receive(:capture3) do |arg1, arg2, arg3|
           options = JSON.parse(arg3)
+
           expect(options['css']).to eq '/test.css'
         end.twice.and_return(response)
+
         subject.fetch
       end
     end
@@ -51,9 +56,12 @@
       it 'generates css for each route from the respective file' do
         expect(Open3).to receive(:capture3) do |arg1, arg2, arg3|
           options = JSON.parse(arg3)
-          expect(options['css']).to eq '/test.css' if options['url'] == 'http://0.0.0.0:9292/'
-          expect(options['css']).to eq '/test2.css' if options['url'] == 'http://0.0.0.0:9292/new_route'
+
+          css_paths.each_with_index do |path, index|
+            expect(options['css']).to eq path if options['url'] == "#{base_url}/#{routes[index]}"
+          end
         end.twice.and_return(response)
+
         subject.fetch
       end
     end
@@ -66,10 +74,12 @@
       it 'generates css for each route from the respective file' do
         expect(Open3).to receive(:capture3) do |arg1, arg2, arg3|
           options = JSON.parse(arg3)
-          expect(options['css']).to eq '/test.css' if options['url'] == 'http://0.0.0.0:9292/'
-          expect(options['css']).to eq '/test2.css' if options['url'] == 'http://0.0.0.0:9292/new_route'
-          expect(options['css']).to eq '/test.css' if options['url'] == 'http://0.0.0.0:9292/newer_route'
+
+          css_paths.each_with_index do |path, index|
+            expect(options['css']).to eq path if options['url'] == "#{base_url}/#{routes[index]}"
+          end
         end.thrice.and_return(response)
+
         subject.fetch
       end
     end

spec/lib/critical_path_css/rails/config_loader_spec.rb

@@ -1,29 +1,15 @@
 require 'spec_helper'
 
 RSpec.describe 'ConfigLoader' do
-  let(:subject) { CriticalPathCss::Rails::ConfigLoader.new }
+  subject { CriticalPathCss::Rails::ConfigLoader.new }
 
   describe '#load' do
     before do
       allow(File).to receive(:read).and_return(config_file)
     end
 
     context 'when single css_path is specified' do
-      let(:config_file) {
-        <<~CONFIG
-          defaults: &defaults
-            base_url: http://0.0.0.0:9292
-            css_path: /test.css
-            routes:
-              - /
-
-          development:
-            <<: *defaults
-
-          test:
-            <<: *defaults
-        CONFIG
-      }
+      let(:config_file) { file_fixture('config/single-css-path.yml').read }
 
       it 'sets css_path with the path' do
         expect(subject.config['css_path']).to eq '/app/spec/internal/public/test.css'
@@ -35,24 +21,7 @@
     end
 
     context 'when multiple css_paths are specified' do
-      let(:config_file) {
-        <<~CONFIG
-          defaults: &defaults
-            base_url: http://0.0.0.0:9292
-            css_paths:
-              - /test.css
-              - /test2.css
-            routes:
-              - /
-              - /new_route
-
-          development:
-            <<: *defaults
-
-          test:
-            <<: *defaults
-        CONFIG
-      }
+      let(:config_file) { file_fixture('config/mutliple-css-paths.yml').read }
 
       it 'sets css_path to empty string' do
         expect(subject.config['css_path']).to eq ''
@@ -64,21 +33,7 @@
     end
 
     context 'when no paths are specified' do
-      let(:config_file) {
-        <<~CONFIG
-          defaults: &defaults
-            base_url: http://0.0.0.0:9292
-            manifest_name: application
-            routes:
-              - /
-
-          development:
-            <<: *defaults
-
-          test:
-            <<: *defaults
-        CONFIG
-      }
+      let(:config_file) { file_fixture('config/no-paths-specified.yml').read }
 
       it 'sets css_path with the path' do
         expect(subject.config['css_path']).to eq '/stylesheets/application.css'
@@ -90,51 +45,15 @@
     end
 
     context 'when single css_path and multiple css_paths are both specified' do
-      let(:config_file) {
-        <<~CONFIG
-          defaults: &defaults
-            base_url: http://0.0.0.0:9292
-            css_path: /test.css
-            css_paths:
-              - /test.css
-              - /test2.css
-            routes:
-              - /
-              - /new_route
-
-          development:
-            <<: *defaults
-
-          test:
-            <<: *defaults
-        CONFIG
-      }
+      let(:config_file) { file_fixture('config/paths-both-specified.yml').read }
 
       it 'raises an error' do
         expect { subject }.to raise_error LoadError, 'Cannot specify both css_path and css_paths'
       end
     end
 
     context 'when css_paths and routes are not the same length' do
-      let(:config_file) {
-        <<~CONFIG
-          defaults: &defaults
-            base_url: http://0.0.0.0:9292
-            css_paths:
-              - /test.css
-              - /test2.css
-            routes:
-              - /
-              - /new_route
-              - /newer_route
-
-          development:
-            <<: *defaults
-
-          test:
-            <<: *defaults
-        CONFIG
-      }
+      let(:config_file) { file_fixture('config/paths-and-routes-not-same-length.yml').read }
 
       it 'raises an error' do
         expect { subject }.to raise_error LoadError, 'Must specify css_paths for each route'