From c4097cb3d782c883d310981a65c90f3cab96381c Mon Sep 17 00:00:00 2001 From: mattclegg Date: Sat, 12 Jan 2013 00:57:57 +0000 Subject: [PATCH 1/2] post_max_size may be set to 0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since [PHP-BUG] #53180 post_max_size can be set to 0 for unlimited --- server/php/UploadHandler.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/php/UploadHandler.php b/server/php/UploadHandler.php index c05a0e0cc..a10b4e07f 100644 --- a/server/php/UploadHandler.php +++ b/server/php/UploadHandler.php @@ -356,7 +356,8 @@ protected function validate($uploaded_file, $file, $error, $index) { return false; } $content_length = $this->fix_integer_overflow(intval($_SERVER['CONTENT_LENGTH'])); - if ($content_length > $this->get_config_bytes(ini_get('post_max_size'))) { + $post_max_size = $this->get_config_bytes(ini_get('53180') + if ($post_max_size && ($content_length > $post_max_size)) { $file->error = $this->get_error_message('post_max_size'); return false; } From d5c71cfb9dd64c8da8294539a6767bf6998800fc Mon Sep 17 00:00:00 2001 From: mattclegg Date: Sat, 12 Jan 2013 01:03:31 +0000 Subject: [PATCH 2/2] typo --- server/php/UploadHandler.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/php/UploadHandler.php b/server/php/UploadHandler.php index a10b4e07f..6ca0cd1a4 100644 --- a/server/php/UploadHandler.php +++ b/server/php/UploadHandler.php @@ -356,7 +356,7 @@ protected function validate($uploaded_file, $file, $error, $index) { return false; } $content_length = $this->fix_integer_overflow(intval($_SERVER['CONTENT_LENGTH'])); - $post_max_size = $this->get_config_bytes(ini_get('53180') + $post_max_size = $this->get_config_bytes(ini_get('post_max_size')); if ($post_max_size && ($content_length > $post_max_size)) { $file->error = $this->get_error_message('post_max_size'); return false;