Skip to content

Commit 1a3e880

Browse files
committed
[css-grid] Remove handled comment. Add issue about flexing from 0->1.
1 parent c70e653 commit 1a3e880

1 file changed

Lines changed: 6 additions & 41 deletions

File tree

css-grid/Overview.bs

Lines changed: 6 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -993,7 +993,7 @@ Track Sizing: the 'grid-template-rows' and 'grid-template-columns' properties</h
993993

994994
<dt><dfn><<flex>></dfn>
995995
<dd>
996-
A non-negative dimension with the unit ''fr'' specifying the track's <dfn noexport>flex factor</dfn>.
996+
A non-negative dimension with the unit ''fr'' specifying the track's <dfn dfn noexport>flex factor</dfn>.
997997
Each <<flex>>-sized track takes a share of the remaining space in proportion to its <a>flex factor</a>.
998998
See <a href="#fr-unit">Flexible Lengths</a> for more details.
999999

@@ -3079,9 +3079,9 @@ Grid Sizing Algorithm</h3>
30793079
using the resulting size of the <a>grid</a> as its content size,
30803080
and the tracks are aligned within the <a>grid container</a>
30813081
according to the 'align-content' and 'justify-content' properties.
3082-
<span class="note">Note: This can introduce extra space within or between tracks.</a>
3083-
(When introducing space within tracks,
3084-
only tracks with an <a lt="intrinsic sizing function">intrinsic</a> <a>max track sizing function</a> accept space.)
3082+
<span class="note">Note: This can introduce extra space within or between tracks.</span>
3083+
When introducing space within tracks,
3084+
only tracks with an ''grid-template-rows/auto'' <a>max track sizing function</a> accept space.
30853085
</ol>
30863086

30873087
Once the size of each <a>grid area</a> is thus established,
@@ -3453,43 +3453,6 @@ Stretch Flexible Tracks</h3>
34533453
is greater than the track's <a>base size</a>,
34543454
set its <a>base size</a> to that product.
34553455

3456-
<!--
3457-
shrinkwrapping FRs
3458-
< min-content case
3459-
* never happens: tracks don't shrink below their base size
3460-
min-content case
3461-
* each flex track at its min-content size, might be uneven
3462-
in-between case
3463-
* each flex track >= min-content size, approaching all FRs equal
3464-
midpoint case
3465-
* each flex track is at least its min-content size, all FRs are equal
3466-
max-content case
3467-
* largest max-content track is at max-content, all FRs are equal
3468-
> max-content case
3469-
* each flex track is at least its max-content size, all FRs are equal
3470-
3471-
Conclusion: 1FR's base size is by default equivalent to min-content,
3472-
we'll say it is equivalent to "use min-size property".
3473-
3474-
Difference in behavior of having min-content size (by accident) vs. sizing under min-content constraint!!!
3475-
Question to author: do you want even FRs, or do you want to minimize overflow? Probably depends on 'overflow', just like in Flexbox! Nope, always minimize overflow. Even FRs will result in tracks beign *larger* than in an equivalent fixed-size container case, which doesn't make sense.
3476-
3477-
I think we can copy the "treat available space as 0/infinite in min/max constraint situations" paragraph down to the flexing paragraph. That'll produce the "minimum size" behavior for flexible things.
3478-
3479-
If you're sizing by intrinsic size, you use max(grid items' content size, grid item's min-size property).
3480-
For flexible lengths, we could do the same thing OR we could just use the grid item's min-size property, treating auto as min-content.
3481-
3482-
Interesting question: should 'auto' mean minmax(min-content, max-content) or minmax('min-size property', max-content)?
3483-
3484-
What effect does min-size: auto vs. 0 have?
3485-
3486-
Consider: minmax(auto, ?) to mean minmax('min-size property', ?)
3487-
Consider: auto to mean minmax(auto, max-content) instead of minmax(min-content, max-content) --
3488-
otherwise if you set a grid item's min-width to 50px, it will still use the min-content size as a minimum;
3489-
this way it honors min-width: 50px, which probably is what you want.
3490-
(Definitely want the default to be min-content, but min-width: auto gives us that.)
3491-
-->
3492-
34933456

34943457
<h4 id="algo-find-fr-size">
34953458
Find the Size of an ''fr''</h4>
@@ -3524,6 +3487,8 @@ Find the Size of an ''fr''</h4>
35243487
Return the <a>hypothetical fr size</a>.
35253488
</ol>
35263489

3490+
Issue: This doesn't yet handle the 0->1 transition properly, like Flexbox does. Fix it.
3491+
35273492
<!--
35283493
████████ ████████ ███ ██████ ██ ██ ████████ ██ ██ ████████ ████ ██ ██ ██████
35293494
██ ██ ██ ██ ██ ██ ██ ███ ███ ██ ███ ██ ██ ██ ███ ██ ██ ██

0 commit comments

Comments
 (0)