Skip to content

Commit 5ee8d37

Browse files
committed
[css-flexbox] I allow max-height to transfer into a max-width constraint when there's an aspect ratio, but didn't allow height to transfer into width.
1 parent f69b87e commit 5ee8d37

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

css-flexbox/Overview.bs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -892,12 +892,13 @@ Implied Minimum Size of Flex Items</h3>
892892
the computed 'width' ('height'),
893893
if that value is <a>definite</a>.
894894
<li>the computed 'max-width' ('max-height'), if that value is <a>definite</a>,
895-
<li>if the item has no intrinsic aspect ratio, its <a>min-content size</a>,
896895
<li>if the item has an intrinsic aspect ratio and a <a>definite</a> 'max-height' ('max-width'),
897896
the width (height) calculated from
898897
the aspect ratio and 'max-height' ('max-width').
899-
<span class="issue">Audit this for correctness.</span>
900-
<li>
898+
<li>if the item has an intrinsic aspect ratio and a <a>definite</a> 'height' ('width'),
899+
the width (height) calculated from
900+
the aspect ratio and 'height' ('width').
901+
<li>if the item has no intrinsic aspect ratio, its <a>min-content size</a>,
901902
</ul>
902903

903904
Otherwise,

css-flexbox/Overview.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1027,12 +1027,13 @@ <h3 class="heading settled" data-level=4.5 id=min-size-auto><span class=secno>4.
10271027
the computed <a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-width title=width>width</a> (<a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-height title=height>height</a>),
10281028
if that value is <a data-link-type=dfn href=#definite title=definite>definite</a>.
10291029
<li>the computed <a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-max-width title=max-width>max-width</a> (<a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-max-height title=max-height>max-height</a>), if that value is <a data-link-type=dfn href=#definite title=definite>definite</a>,
1030-
<li>if the item has no intrinsic aspect ratio, its <a data-link-type=dfn href=http://dev.w3.org/csswg/css-sizing-3/#min-content-inline-size title="min-content size">min-content size</a>,
10311030
<li>if the item has an intrinsic aspect ratio and a <a data-link-type=dfn href=#definite title=definite>definite</a> <a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-max-height title=max-height>max-height</a> (<a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-max-width title=max-width>max-width</a>),
10321031
the width (height) calculated from
10331032
the aspect ratio and <a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-max-height title=max-height>max-height</a> (<a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-max-width title=max-width>max-width</a>).
1034-
<span class=issue id=issue-3e8af8e3><a class=self-link href=#issue-3e8af8e3></a>Audit this for correctness.</span>
1035-
<li>
1033+
<li>if the item has an intrinsic aspect ratio and a <a data-link-type=dfn href=#definite title=definite>definite</a> <a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-height title=height>height</a> (<a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-width title=width>width</a>),
1034+
the width (height) calculated from
1035+
the aspect ratio and <a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-height title=height>height</a> (<a class=property data-link-type=propdesc href=http://dev.w3.org/csswg/css2/visudet.html#propdef-width title=width>width</a>).
1036+
<li>if the item has no intrinsic aspect ratio, its <a data-link-type=dfn href=http://dev.w3.org/csswg/css-sizing-3/#min-content-inline-size title="min-content size">min-content size</a>,
10361037
</ul>
10371038

10381039
<p>Otherwise,
@@ -3824,5 +3825,5 @@ <h2 class="no-num no-ref heading settled" id=property-index><span class=content>
38243825

38253826

38263827
<h2 class="no-num heading settled" id=issues-index><span class=content>Issues Index</span><a class=self-link href=#issues-index></a></h2><div style="counter-reset: issue"><div class=issue>This section is worded badly,
3827-
because 2.1 is incoherent about what "static position" really is.<a href=#issue-bb26f057></a></div><div class=issue>Audit this for correctness.<a href=#issue-3e8af8e3></a></div><div class=issue>This value was originally named "auto",
3828+
because 2.1 is incoherent about what "static position" really is.<a href=#issue-bb26f057></a></div><div class=issue>This value was originally named "auto",
38283829
but that was confusing<a href=#issue-cdba524f></a></div></div>

0 commit comments

Comments
 (0)