Skip to content

Commit 8620660

Browse files
committed
[css-font-loading] Add issue about the base url used to resolve relative urls in FontFace constructor.
1 parent 50acb70 commit 8620660

2 files changed

Lines changed: 22 additions & 1 deletion

File tree

css-font-loading/Overview.bs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,13 @@ The Constructor</h3>
208208
specify the type of font each fallback is,
209209
and refer to local fonts easily.
210210

211+
Issue: Need to define the base url,
212+
so relative urls can resolve.
213+
Should it be the url of the document?
214+
Is that correct for workers too,
215+
or should they use their worker url?
216+
Is that always defined?
217+
211218
If the <a>source</a> argument was a <a>BinaryData</a>,
212219
set <var>font face's</var> internal <a>[<!---->[Data]]</a> slot to the passed argument.
213220

css-font-loading/Overview.html

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,13 @@ <h3 class="heading settled heading" data-level=2.1 id=font-face-constructor><spa
336336
specify the type of font each fallback is,
337337
and refer to local fonts easily.</p>
338338

339+
<p class=issue id=issue-46e5892e><a class=self-link href=#issue-46e5892e></a>Need to define the base url,
340+
so relative urls can resolve.
341+
Should it be the url of the document?
342+
Is that correct for workers too,
343+
or should they use their worker url?
344+
Is that always defined?</p>
345+
339346
<p>If the <a data-link-type=idl href=#dom-fontfacefontface-source title=source>source</a> argument was a <a data-link-type=idl href=#typedefdef-binarydata title=binarydata>BinaryData</a>,
340347
set <var>font face’s</var> internal <a data-link-type=idl href=#dom-fontface-data title=[[data]]>[[Data]]</a> slot to the passed argument.</p>
341348

@@ -1317,7 +1324,14 @@ <h2 class="no-num no-ref heading settled heading" id=property-index><span class=
13171324
<div data-fill-with=property-index><p>No properties defined.</div>
13181325

13191326

1320-
<h2 class="no-num heading settled" id=issues-index><span class=content>Issues Index</span><a class=self-link href=#issues-index></a></h2><div style="counter-reset: issue"><div class=issue>The above is wrong; it assumes that you’re only asking about the <a data-link-type=dfn href=#font-source title="font source">font source</a>.
1327+
<h2 class="no-num heading settled" id=issues-index><span class=content>Issues Index</span><a class=self-link href=#issues-index></a></h2><div style="counter-reset: issue"><div class=issue>Need to define the base url,
1328+
so relative urls can resolve.
1329+
Should it be the url of the document?
1330+
Is that correct for workers too,
1331+
or should they use their worker url?
1332+
Is that always defined?<a href=#issue-46e5892e></a></div>
1333+
1334+
<div class=issue>The above is wrong; it assumes that you’re only asking about the <a data-link-type=dfn href=#font-source title="font source">font source</a>.
13211335
The <a data-link-for=FontFaceSet data-link-type=idl href=#dom-fontfaceset-status title=status>status</a> promise needs to pay attention to what <a data-link-type=idl href=#dom-fontfaceset title=fontfaceset>FontFaceSet</a> it’s attached to.
13221336
I guess only the <a data-link-type=dfn href=#font-source title="font source’s">font source’s</a> <a data-link-for=FontFaceSet data-link-type=idl href=#dom-fontfaceset-status title=status>status</a> promise should care about pending layout operations.<a href=#issue-bf2e5cbe></a></div>
13231337

0 commit comments

Comments
 (0)