Skip to content

Commit a70637d

Browse files
author
Sylvain Galineau
committed
[css-animations] No luck having Bikeshed mark up in-spec issues; reverting to explicit markup
1 parent 170769d commit a70637d

2 files changed

Lines changed: 49 additions & 12 deletions

File tree

css-animations/Overview.bs

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,10 @@ Keyframes</h2>
193193
'animation-timing-function', the behavior of which is described below. In addition, keyframe rule
194194
declarations qualified with !important are ignored.
195195

196-
Issue: Need to describe what happens if a property is not present in all keyframes.
197-
196+
<p class="issue">
197+
Need to describe what happens if a property is not present in all keyframes.
198+
</p>
199+
198200
The @keyframes rule that is used by an animation will be the last one encountered in sorted rules
199201
order that matches the name of the animation specified by the 'animation-name' property. It must be
200202
noted that @keyframes rules cascade; therefore, an animation may derive keyframes from more than one
@@ -695,12 +697,16 @@ The 'animation-fill-mode' property</h3>
695697
but a forwards fill will still apply the values of the ''100%'' keyframe,
696698
not whatever values were being applied at the time the animation stopped executing.
697699

698-
Issue: Why does it ignore the progress made by a non-integer iteration count?
700+
<p class="issue">
701+
Why does it ignore the progress made by a non-integer iteration count?
702+
</p>
699703

700-
Issue: What happens with ''animation-duration: 0; animation-iteration-count: infinite;''?
704+
<p class="issue">
705+
What happens with ''animation-duration: 0; animation-iteration-count: infinite;''?
701706
The animation is instantaneous,
702707
but there is no "last complete iteration".
703708
In particular, you can't tell whether to use the 0% or 100% keyframe.
709+
</p>
704710

705711
<dt><dfn>backwards</dfn>
706712
<dd>
@@ -778,8 +784,10 @@ Animation Events</h2>
778784
Any animation for which both a valid keyframe rule and a non-zero duration are defined will run
779785
and generate events; this includes animations with empty keyframe rules.
780786

781-
Issue: This contradicts the 'animation-delay' section,
787+
<p class="issue">
788+
This contradicts the 'animation-delay' section,
782789
which says that a ''0s'' duration animation still fires events.
790+
</p>
783791

784792
The time the animation has been running is sent with each event generated. This allows the event
785793
handler to determine the current iteration of a looping animation or the current position of an

css-animations/Overview.html

Lines changed: 36 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,8 @@ <h2 class="no-num no-toc no-ref heading settled heading" id=contents><span class
162162
<li><a href=#normative><span class=secno></span> Normative References</a>
163163
<li><a href=#informative><span class=secno></span> Informative References</a></ul>
164164
<li><a href=#index><span class=secno></span> Index</a>
165-
<li><a href=#property-index><span class=secno></span> Property index</a></ul></div>
165+
<li><a href=#property-index><span class=secno></span> Property index</a>
166+
<li><a href=#issues-index><span class=secno></span>Issues Index</a></ul></div>
166167

167168

168169

@@ -334,8 +335,10 @@ <h2 class="heading settled heading" data-level=4 id=keyframes><span class=secno>
334335
<a class=property data-link-type=propdesc href=#propdef-animation-timing-function title=animation-timing-function>animation-timing-function</a>, the behavior of which is described below. In addition, keyframe rule
335336
declarations qualified with !important are ignored.
336337

337-
<p> Issue: Need to describe what happens if a property is not present in all keyframes.
338-
338+
<p class=issue id=issue-f48af4a5><a class=self-link href=#issue-f48af4a5></a>
339+
Need to describe what happens if a property is not present in all keyframes.
340+
</p>
341+
339342
<p> The @keyframes rule that is used by an animation will be the last one encountered in sorted rules
340343
order that matches the name of the animation specified by the <a class=property data-link-type=propdesc href=#propdef-animation-name title=animation-name>animation-name</a> property. It must be
341344
noted that @keyframes rules cascade; therefore, an animation may derive keyframes from more than one
@@ -730,12 +733,16 @@ <h3 class="heading settled heading" data-level=4.9 id=animation-fill-mode><span
730733
but a forwards fill will still apply the values of the <span class=css data-link-type=maybe title=100%>100%</span> keyframe,
731734
not whatever values were being applied at the time the animation stopped executing.
732735

733-
<p> Issue: Why does it ignore the progress made by a non-integer iteration count?
736+
<p class=issue id=issue-34f9fa42><a class=self-link href=#issue-34f9fa42></a>
737+
Why does it ignore the progress made by a non-integer iteration count?
738+
</p>
734739

735-
<p> Issue: What happens with <a class=css data-link-type=propdesc href=#propdef-animation-duration title=animation-duration>animation-duration: 0; animation-iteration-count: infinite;</a>?
740+
<p class=issue id=issue-f125a3b9><a class=self-link href=#issue-f125a3b9></a>
741+
What happens with <a class=css data-link-type=propdesc href=#propdef-animation-duration title=animation-duration>animation-duration: 0; animation-iteration-count: infinite;</a>?
736742
The animation is instantaneous,
737743
but there is no "last complete iteration".
738744
In particular, you can’t tell whether to use the 0% or 100% keyframe.
745+
</p>
739746

740747
<dt><dfn class=css-code data-dfn-for=animation-fill-mode data-dfn-type=value data-export="" id=valuedef-backwards>backwards<a class=self-link href=#valuedef-backwards></a></dfn>
741748
<dd>
@@ -801,8 +808,10 @@ <h2 class="heading settled heading" data-level=5 id=events><span class=secno>5 <
801808
<p> Any animation for which both a valid keyframe rule and a non-zero duration are defined will run
802809
and generate events; this includes animations with empty keyframe rules.
803810

804-
<p> Issue: This contradicts the <a class=property data-link-type=propdesc href=#propdef-animation-delay title=animation-delay>animation-delay</a> section,
811+
<p class=issue id=issue-4b23f62f><a class=self-link href=#issue-4b23f62f></a>
812+
This contradicts the <a class=property data-link-type=propdesc href=#propdef-animation-delay title=animation-delay>animation-delay</a> section,
805813
which says that a <span class=css data-link-type=maybe title=0s>0s</span> duration animation still fires events.
814+
</p>
806815

807816
<p> The time the animation has been running is sent with each event generated. This allows the event
808817
handler to determine the current iteration of a looping animation or the current position of an
@@ -1315,4 +1324,24 @@ <h2 class="no-num no-ref heading settled heading" id=property-index><span class=
13151324
<tr><th scope=row><a data-property="">animation</a><td>&lt;single-animation&gt;#<td>see individual properties<td>all elements, ::before and ::after pseudo-elements<td>no<td>N/A<td>visual<td>no<td>per grammar<td>As specified</table></div>
13161325

13171326

1318-
</ul>
1327+
</ul><h2 class="no-num heading settled" id=issues-index><span class=content>Issues Index</span><a class=self-link href=#issues-index></a></h2><div style="counter-reset: issue"><div class=issue>
1328+
Need to describe what happens if a property is not present in all keyframes.
1329+
<a href=#issue-f48af4a5></a></div>
1330+
1331+
<div class=issue>
1332+
Why does it ignore the progress made by a non-integer iteration count?
1333+
<a href=#issue-34f9fa42></a></div>
1334+
1335+
<div class=issue>
1336+
What happens with <a class=css data-link-type=propdesc href=#propdef-animation-duration title=animation-duration>animation-duration: 0; animation-iteration-count: infinite;</a>?
1337+
The animation is instantaneous,
1338+
but there is no "last complete iteration".
1339+
In particular, you can’t tell whether to use the 0% or 100% keyframe.
1340+
<a href=#issue-f125a3b9></a></div>
1341+
1342+
<div class=issue>
1343+
This contradicts the <a class=property data-link-type=propdesc href=#propdef-animation-delay title=animation-delay>animation-delay</a> section,
1344+
which says that a <span class=css data-link-type=maybe title=0s>0s</span> duration animation still fires events.
1345+
<a href=#issue-4b23f62f></a></div>
1346+
1347+
</div>

0 commit comments

Comments
 (0)