Button: pr comments

arschmitz · arschmitz · commit 0ea40b7cae06 · 2014-10-17T11:28:03.000-04:00
diff --git a/ui/button.js b/ui/button.js
@@ -129,15 +129,14 @@ $.widget( "ui.button", {
 		}
 
 		this.icon.addClass( icon ).appendTo( this.element );
-		return this;
 	},
 
 	_destroy: function() {
 		this.element
 			.removeClass( baseClasses + " ui-state-active " + typeClasses )
 			.removeAttr( "role" );
 
-		if ( this.icon !== undefined ) {
+		if ( this.icon ) {
 			this.icon.remove();
 		}
 		if ( !this.hasTitle ) {

Original file line number	Diff line number	Diff line change
`@@ -129,15 +129,14 @@ $.widget( "ui.button", {`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`this.icon.addClass( icon ).appendTo( this.element );`
`132`		`- return this;`
`133`	`132`	`},`
`134`	`133`
`135`	`134`	`_destroy: function() {`
`136`	`135`	`this.element`
`137`	`136`	`.removeClass( baseClasses + " ui-state-active " + typeClasses )`
`138`	`137`	`.removeAttr( "role" );`
`139`	`138`
`140`		`- if ( this.icon !== undefined ) {`
	`139`	`+ if ( this.icon ) {`
`141`	`140`	`this.icon.remove();`
`142`	`141`	`}`
`143`	`142`	`if ( !this.hasTitle ) {`