Dialog: Append close button to first found header to prevent a close button being added to popup on same page as well. Fixes jquery-archive#5382.

jaspermdegroot · jaspermdegroot · commit 0e140f9cfbfd · 2012-12-16T21:35:42.000+01:00
diff --git a/js/widgets/dialog.js b/js/widgets/dialog.js
@@ -86,7 +86,7 @@ $.widget( "mobile.dialog", $.mobile.widget, {
 			// Sanitize value
 			location = ( value === "left" ? "left" : "right" );
 			btn = $( "<a href='#' class='ui-btn-" + location + "' data-" + $.mobile.ns + "icon='delete' data-" + $.mobile.ns + "iconpos='notext'>"+ this.options.closeBtnText + "</a>" );
-			this.element.children().find( ":jqmData(role='header')" ).prepend( btn );
+			this.element.children().find( ":jqmData(role='header')" ).first().prepend( btn );
 			if ( this._createComplete && $.fn.buttonMarkup ) {
 				btn.buttonMarkup();
 			}

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ $.widget( "mobile.dialog", $.mobile.widget, {`
`86`	`86`	`// Sanitize value`
`87`	`87`	`location = ( value === "left" ? "left" : "right" );`
`88`	`88`	`btn = $( "<a href='#' class='ui-btn-" + location + "' data-" + $.mobile.ns + "icon='delete' data-" + $.mobile.ns + "iconpos='notext'>"+ this.options.closeBtnText + "</a>" );`
`89`		`- this.element.children().find( ":jqmData(role='header')" ).prepend( btn );`
	`89`	`+ this.element.children().find( ":jqmData(role='header')" ).first().prepend( btn );`
`90`	`90`	`if ( this._createComplete && $.fn.buttonMarkup ) {`
`91`	`91`	`btn.buttonMarkup();`
`92`	`92`	`}`