Define arrays out of foreach

TheCrowned · web-flow · commit 1fc0b0662805 · 2019-03-23T09:24:22.000+01:00
diff --git a/includes/class-creativecommons-image.php b/includes/class-creativecommons-image.php
@@ -295,7 +295,8 @@ function add_image_license_metadata($form_fields, $post)
 
     function save_image_license_metadata($post, $attachment) 
     {
-        foreach ( array( 'license_url', 'attribution_url', 'source_work_url', 'extra_permissions_url' ) as $field) {
+        $image_meta = array( 'license_url', 'attribution_url', 'source_work_url', 'extra_permissions_url' );
+        foreach ( $image_meta as $field ) {
             if (isset($attachment[$field])) {
                 update_post_meta(
                     $post['ID'],
@@ -304,7 +305,9 @@ function save_image_license_metadata($post, $attachment)
                 );
             }
         }
-        foreach ( array( 'attribution_name' ) as $field) {
+      
+        $image_meta_no_sanitization = array( 'attribution_name' );
+        foreach ( $image_meta_no_sanitization as $field ) {
             if (isset($attachment[$field])) {
                 update_post_meta(
                     $post['ID'],

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,8 @@ function add_image_license_metadata($form_fields, $post)`
`295`	`295`
`296`	`296`	`function save_image_license_metadata($post, $attachment)`
`297`	`297`	`{`
`298`		`- foreach ( array( 'license_url', 'attribution_url', 'source_work_url', 'extra_permissions_url' ) as $field) {`
	`298`	`+ $image_meta = array( 'license_url', 'attribution_url', 'source_work_url', 'extra_permissions_url' );`
	`299`	`+ foreach ( $image_meta as $field ) {`
`299`	`300`	`if (isset($attachment[$field])) {`
`300`	`301`	`update_post_meta(`
`301`	`302`	`$post['ID'],`
`@@ -304,7 +305,9 @@ function save_image_license_metadata($post, $attachment)`
`304`	`305`	`);`
`305`	`306`	`}`
`306`	`307`	`}`
`307`		`- foreach ( array( 'attribution_name' ) as $field) {`
	`308`	`+`
	`309`	`+ $image_meta_no_sanitization = array( 'attribution_name' );`
	`310`	`+ foreach ( $image_meta_no_sanitization as $field ) {`
`308`	`311`	`if (isset($attachment[$field])) {`
`309`	`312`	`update_post_meta(`
`310`	`313`	`$post['ID'],`