Skip to content

Commit a97b49e

Browse files
committed
Add content disposition inline to json responses to help IE8
blueimp/jQuery-File-Upload#235 has a discussion about IE wanting to download the script instead of running it. I really do not know if it is necessary here, but I want this version to be bullet proof.
1 parent 1229f53 commit a97b49e

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

fileupload/views.py

+7-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@ def form_valid(self, form):
2020
self.object = form.save()
2121
f = self.request.FILES.get('file')
2222
data = [{'name': f.name, 'url': settings.MEDIA_URL + "pictures/" + f.name, 'thumbnail_url': settings.MEDIA_URL + "pictures/" + f.name, 'delete_url': reverse('upload-delete', args=[self.object.id]), 'delete_type': "DELETE"}]
23-
return JSONResponse(data, {}, response_mimetype(self.request))
23+
response = JSONResponse(data, {}, response_mimetype(self.request))
24+
response['Content-Disposition'] = 'inline; filename=files.json'
25+
return response
26+
2427

2528
class PictureDeleteView(DeleteView):
2629
model = Picture
@@ -32,7 +35,9 @@ def delete(self, request, *args, **kwargs):
3235
"""
3336
self.object = self.get_object()
3437
self.object.delete()
35-
return JSONResponse(True, {}, response_mimetype(self.request))
38+
response = JSONResponse(True, {}, response_mimetype(self.request))
39+
response['Content-Disposition'] = 'inline; filename=files.json'
40+
return response
3641

3742
class JSONResponse(HttpResponse):
3843
"""JSON response class."""

0 commit comments

Comments
 (0)