Skip to content

Commit 0352c2c

Browse files
jzaeffererjzaefferer
committed
Menu: Remove default preventDefault. Add more meaningful href's on menu
and menubar demos. Change doesn't seem to affect autocomplete as that doesn't use href-attributes anyway.
1 parent c17f245 commit 0352c2c

File tree

4 files changed

+74
-76
lines changed

4 files changed

+74
-76
lines changed

‎demos/menu/contextmenu.html‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@
3737

3838
<button>Select a city</button>
3939
<ul>
40-
<li><a href="#">Amsterdam</a></li>
41-
<li><a href="#">Anaheim</a></li>
42-
<li><a href="#">Cologne</a></li>
43-
<li><a href="#">Frankfurt</a></li>
44-
<li><a href="#">Magdeburg</a></li>
45-
<li><a href="#">Munich</a></li>
46-
<li><a href="#">Utrecht</a></li>
47-
<li><a href="#">Zurich</a></li>
40+
<li><a href="#Amsterdam">Amsterdam</a></li>
41+
<li><a href="#Anaheim">Anaheim</a></li>
42+
<li><a href="#Cologne">Cologne</a></li>
43+
<li><a href="#Frankfurt">Frankfurt</a></li>
44+
<li><a href="#Magdeburg">Magdeburg</a></li>
45+
<li><a href="#Munich">Munich</a></li>
46+
<li><a href="#Utrecht">Utrecht</a></li>
47+
<li><a href="#Zurich">Zurich</a></li>
4848
</ul>
4949

5050
<div id="log"></div>

‎demos/menu/default.html‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,21 @@
2323
<div class="demo">
2424

2525
<ul>
26-
<li><a href="#">Aberdeen</a></li>
27-
<li><a href="#">Ada</a></li>
28-
<li><a href="#">Adamsville</a></li>
29-
<li><a href="#">Addyston</a></li>
30-
<li><a href="#">Adelphi</a></li>
31-
<li><a href="#">Adena</a></li>
32-
<li><a href="#">Adrian</a></li>
33-
<li><a href="#">Akron</a></li>
34-
<li><a href="#">Albany</a></li>
35-
<li><a href="#">Alexandria</a></li>
36-
<li><a href="#">Alger</a></li>
37-
<li><a href="#">Alledonia</a></li>
38-
<li><a href="#">Alliance</a></li>
39-
<li><a href="#">Alpha</a></li>
40-
<li><a href="#">Alvada</a></li>
26+
<li><a href="#Aberdeen">Aberdeen</a></li>
27+
<li><a href="#Ada">Ada</a></li>
28+
<li><a href="#Adamsville">Adamsville</a></li>
29+
<li><a href="#Addyston">Addyston</a></li>
30+
<li><a href="#Adelphi">Adelphi</a></li>
31+
<li><a href="#Adena">Adena</a></li>
32+
<li><a href="#Adrian">Adrian</a></li>
33+
<li><a href="#Akron">Akron</a></li>
34+
<li><a href="#Albany">Albany</a></li>
35+
<li><a href="#Alexandria">Alexandria</a></li>
36+
<li><a href="#Alger">Alger</a></li>
37+
<li><a href="#Alledonia">Alledonia</a></li>
38+
<li><a href="#Alliance">Alliance</a></li>
39+
<li><a href="#Alpha">Alpha</a></li>
40+
<li><a href="#Alvada">Alvada</a></li>
4141
</ul>
4242

4343
</div><!-- End demo -->

‎demos/menubar/default.html‎

Lines changed: 51 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -70,92 +70,92 @@
7070
<div class="demo">
7171
<ul id="bar1" class="menubar">
7272
<li>
73-
<a href="#">File</a>
73+
<a href="#File">File</a>
7474
<ul>
75-
<li><a href="#">Open...</a></li>
75+
<li><a href="#Open...">Open...</a></li>
7676
<li class="ui-state-disabled">Open recent...</li>
77-
<li><a href="#">Save</a></li>
78-
<li><a href="#">Save as...</a></li>
79-
<li><a href="#">Close</a></li>
80-
<li><a href="#">Quit</a></li>
77+
<li><a href="#Save">Save</a></li>
78+
<li><a href="#Save as...">Save as...</a></li>
79+
<li><a href="#Close">Close</a></li>
80+
<li><a href="#Quit">Quit</a></li>
8181
</ul>
8282
</li>
8383
<li>
84-
<a href="#">Edit</a>
84+
<a href="#Edit">Edit</a>
8585
<ul>
86-
<li><a href="#">Copy</a></li>
87-
<li><a href="#">Cut</a></li>
86+
<li><a href="#Copy">Copy</a></li>
87+
<li><a href="#Cut">Cut</a></li>
8888
<li class="ui-state-disabled">Paste</li>
8989
</ul>
9090
</li>
9191
<li>
92-
<a href="#">View</a>
92+
<a href="#View">View</a>
9393
<ul>
94-
<li><a href="#">Fullscreen</a></li>
95-
<li><a href="#">Fit into view</a></li>
94+
<li><a href="#Fullscreen">Fullscreen</a></li>
95+
<li><a href="#Fit into view">Fit into view</a></li>
9696
<li>
97-
<a href="#">Encoding</a>
97+
<a href="#Encoding">Encoding</a>
9898
<ul>
99-
<li><a href="#">Auto-detect</a></li>
100-
<li><a href="#">UTF-8</a></li>
99+
<li><a href="#Auto-detect">Auto-detect</a></li>
100+
<li><a href="#UTF-8">UTF-8</a></li>
101101
<li>
102-
<a href="#">UTF-16</a>
102+
<a href="#UTF-16">UTF-16</a>
103103
<ul>
104-
<li><a href="#">Option 1</a></li>
105-
<li><a href="#">Option 2</a></li>
106-
<li><a href="#">Option 3</a></li>
107-
<li><a href="#">Option 4</a></li>
104+
<li><a href="#Option 1">Option 1</a></li>
105+
<li><a href="#Option 2">Option 2</a></li>
106+
<li><a href="#Option 3">Option 3</a></li>
107+
<li><a href="#Option 4">Option 4</a></li>
108108
</ul>
109109
</li>
110110
</ul>
111111
</li>
112-
<li><a href="#">Customize...</a></li>
112+
<li><a href="#Customize...">Customize...</a></li>
113113
</ul>
114114
</li>
115115
</ul>
116116

117117
<ul id="bar2" class="menubar-icons">
118118
<li>
119-
<a href="#">File</a>
119+
<a href="#File">File</a>
120120
<ul>
121-
<li><a href="#">Open...</a></li>
121+
<li><a href="#Open...">Open...</a></li>
122122
<li class="ui-state-disabled">Open recent...</li>
123-
<li><a href="#">Save</a></li>
124-
<li><a href="#">Save as...</a></li>
125-
<li><a href="#">Close</a></li>
126-
<li><a href="#">Quit</a></li>
123+
<li><a href="#Save">Save</a></li>
124+
<li><a href="#Save as...">Save as...</a></li>
125+
<li><a href="#Close">Close</a></li>
126+
<li><a href="#Quit">Quit</a></li>
127127
</ul>
128128
</li>
129129
<li>
130-
<a href="#">Edit</a>
130+
<a href="#Edit">Edit</a>
131131
<ul>
132-
<li><a href="#">Copy</a></li>
133-
<li><a href="#">Cut</a></li>
132+
<li><a href="#Copy">Copy</a></li>
133+
<li><a href="#Cut">Cut</a></li>
134134
<li class="ui-state-disabled">Paste</li>
135135
</ul>
136136
</li>
137137
<li>
138-
<a href="#">View</a>
138+
<a href="#View">View</a>
139139
<ul>
140-
<li><a href="#">Fullscreen</a></li>
141-
<li><a href="#">Fit into view</a></li>
140+
<li><a href="#Fullscreen">Fullscreen</a></li>
141+
<li><a href="#Fit into view">Fit into view</a></li>
142142
<li>
143-
<a href="#">Encoding</a>
143+
<a href="#Encoding">Encoding</a>
144144
<ul>
145-
<li><a href="#">Auto-detect</a></li>
146-
<li><a href="#">UTF-8</a></li>
145+
<li><a href="#Auto-detect">Auto-detect</a></li>
146+
<li><a href="#UTF-8">UTF-8</a></li>
147147
<li>
148-
<a href="#">UTF-16</a>
148+
<a href="#UTF-16">UTF-16</a>
149149
<ul>
150-
<li><a href="#">Option 1</a></li>
151-
<li><a href="#">Option 2</a></li>
152-
<li><a href="#">Option 3</a></li>
153-
<li><a href="#">Option 4</a></li>
150+
<li><a href="#Option 1">Option 1</a></li>
151+
<li><a href="#Option 2">Option 2</a></li>
152+
<li><a href="#Option 3">Option 3</a></li>
153+
<li><a href="#Option 4">Option 4</a></li>
154154
</ul>
155155
</li>
156156
</ul>
157157
</li>
158-
<li><a href="#">Customize...</a></li>
158+
<li><a href="#Customize...">Customize...</a></li>
159159
</ul>
160160
</li>
161161
</ul>
@@ -178,19 +178,19 @@
178178
<td class="ui-widget-content">
179179
<ul class="menubar">
180180
<li>
181-
<a href="#">Options</a>
181+
<a href="#Options">Options</a>
182182
<ul>
183-
<li><a href="#">Order...</a></li>
183+
<li><a href="#Order...">Order...</a></li>
184184
<li class="ui-state-disabled">Write a Review...</li>
185-
<li><a href="#">Find Similar Movies...</a></li>
185+
<li><a href="#Find Similar Movies...">Find Similar Movies...</a></li>
186186
<li>
187-
<a href="#">Rate</a>
187+
<a href="#Rate">Rate</a>
188188
<ul>
189-
<li><a href="#">5 stars</a></li>
190-
<li><a href="#">4 stars</a></li>
191-
<li><a href="#">3 stars</a></li>
192-
<li><a href="#">2 stars</a></li>
193-
<li><a href="#">1 stars</a></li>
189+
<li><a href="#5 stars">5 stars</a></li>
190+
<li><a href="#4 stars">4 stars</a></li>
191+
<li><a href="#3 stars">3 stars</a></li>
192+
<li><a href="#2 stars">2 stars</a></li>
193+
<li><a href="#1 stars">1 stars</a></li>
194194
</ul>
195195
</li>
196196
</ul>

‎ui/jquery.ui.menu.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ $.widget("ui.menu", {
4545
if ( !item.length ) {
4646
return;
4747
}
48-
// temporary
49-
event.preventDefault();
5048
// it's possible to click an item without hovering it (#7085)
5149
if ( !self.active || ( self.active[ 0 ] !== item[ 0 ] ) ) {
5250
self.focus( event, item );

0 commit comments

Comments
 (0)