Skip to content

Commit e4a4299

Browse files
author
David Murdoch
committed
Removing unnecessary variables, caching 'within' in tests where its beneficial, and making some other changes based on the code review
1 parent f798b04 commit e4a4299

File tree

3 files changed

+83
-201
lines changed

3 files changed

+83
-201
lines changed

tests/unit/position/position_core.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,8 @@ test( "collision: fit, with offset", function() {
314314
test( "collision: fit, window scrolled", function() {
315315
if ( scrollTopSupport() ) {
316316
var win = $( window );
317-
$( window ).scrollTop( 300 ).scrollLeft( 200 );
317+
win.scrollTop( 300 ).scrollLeft( 200 );
318+
318319
collisionTest({
319320
collision: "fit",
320321
at: "left-100 top-100"
@@ -323,7 +324,7 @@ test( "collision: fit, window scrolled", function() {
323324
collision: "fit",
324325
at: "right+100 bottom+100"
325326
}, { top: 300 + win.height() - 10, left: 200 + win.width() - 10 }, "right bottom" );
326-
327+
327328
win.scrollTop( 0 ).scrollLeft( 0 );
328329
}
329330
});

0 commit comments

Comments
 (0)