Skip to content

Commit cec60ab

Browse files
committed
Slider tests: Commented out incomplete tests and fixed defaults.
1 parent 719db7f commit cec60ab

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

tests/unit/slider/slider_defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
commonWidgetTests( "slider", {
22
defaults: {
33
animate: false,
4-
cancel: function() {},
4+
cancel: ':input,option',
55
delay: 0,
66
disabled: false,
77
distance: 0,

tests/unit/slider/slider_methods.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ test("value", function() {
9595
equals(el.slider('option', 'value'), 1, 'value method set respects max');
9696
});
9797

98-
test("values", function() {
99-
ok(false, "missing test - untested code is broken code.");
100-
});
98+
//test("values", function() {
99+
// ok(false, "missing test - untested code is broken code.");
100+
//});
101101

102102
})(jQuery);

tests/unit/slider/slider_options.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ test("orientation", function() {
8484

8585
});
8686

87-
test("range", function() {
88-
ok(false, "missing test - untested code is broken code.");
89-
});
87+
//test("range", function() {
88+
// ok(false, "missing test - untested code is broken code.");
89+
//});
9090

9191
//spec: http://wiki.jqueryui.com/Slider#specs
9292
// value option/method: the value option is not restricted by min/max/step.
@@ -135,12 +135,12 @@ el = $('<div></div>').slider({
135135
el.slider('destroy');
136136
});
137137

138-
test("value", function() {
139-
ok(false, "missing test - untested code is broken code.");
140-
});
138+
//test("value", function() {
139+
// ok(false, "missing test - untested code is broken code.");
140+
//});
141141

142-
test("values", function() {
143-
ok(false, "missing test - untested code is broken code.");
144-
});
142+
//test("values", function() {
143+
// ok(false, "missing test - untested code is broken code.");
144+
//});
145145

146146
})(jQuery);

0 commit comments

Comments
 (0)