Skip to content

Commit c227535

Browse files
author
scottjehl
committed
removed vclick + click combined event binding, which was in there as a workaround for a not-consistently-occurring bug in Android 2.1. I think the real issue is related to lack of dynamic base tag support, and that occasionally, a relative href click will use default handling in 2.1 and go where it shouldn't (ignoring the base href). Either way, this double binding causes history problems in Safari, so I'm removing it while we search for a better 2.1 workaround. Fixes jquery-archive#1870
1 parent 3e3a574 commit c227535

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

js/jquery.mobile.navigation.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -999,12 +999,7 @@
999999
});
10001000

10011001
// click routing - direct to HTTP or Ajax, accordingly
1002-
// TODO: most of the time, vclick will be all we need for fastClick bulletproofing.
1003-
// However, it seems that in Android 2.1, a click event
1004-
// will occasionally arrive independently of the bound vclick
1005-
// binding to click as well seems to help in this edge case
1006-
// we'll dig into this further in the next release cycle
1007-
$( document ).bind( $.mobile.useFastClick ? "vclick click" : "click", function( event ) {
1002+
$( document ).bind( $.mobile.useFastClick ? "vclick" : "click", function( event ) {
10081003
var link = findClosestLink( event.target );
10091004
if ( !link ) {
10101005
return;

0 commit comments

Comments
 (0)