Skip to content

Commit 847a808

Browse files
committed
Feedback from review
1 parent 1e1e534 commit 847a808

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

css-view-transitions-1/Overview.bs

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -447,6 +447,9 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn;
447447
:: A {{CSSStyleRule}} or null. Initially null.
448448
</dl>
449449

450+
Note: These are used to update, and later remove styles
451+
from a [=document=]'s [=document/view transition style sheet=].
452+
450453
## Additions to {{Document}} ## {#additions-to-document}
451454

452455
A {{Document}} additionally has:
@@ -710,7 +713,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn;
710713

711714
1. Set |capture|'s [=old image=] to the result of [=capturing the image=] of |element|.
712715

713-
1. Set |capture|'s [=old styles=] to the following:
716+
1. Set |capture|'s [=captured element/old styles=] to the following:
714717

715718
: 'transform'
716719
:: A CSS transform that would place |element|
@@ -1041,7 +1044,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn;
10411044

10421045
1. Append |old| to |imagePair|.
10431046

1044-
1. Let |oldViewBox| be |capturedElement|'s [=old styles=] 'object-view-box' property.
1047+
1. Let |oldViewBox| be |capturedElement|'s [=captured element/old styles=] 'object-view-box' property.
10451048

10461049
1. Set |capturedElement|'s [=captured element/old view-box rule=] to a new {{CSSStyleRule}} representing the following CSS,
10471050
and append it to |document|'s [=document/view transition style sheet=].
@@ -1071,13 +1074,14 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn;
10711074
are not painted (as if they had visibility: hidden)
10721075
and do not respond to hit-testing (as if they had pointer-events: none) until |new| exists.
10731076

1074-
1. If neither of |capturedElement|'s [=captured element/old image=] or [=captured element/new element=] is null:
1077+
1. If both of |capturedElement|'s [=captured element/old image=] and [=captured element/new element=]
1078+
are not null, then:
10751079

1076-
1. Let |transform| be |capturedElement|'s [=old styles=]'s 'transform' property.
1080+
1. Let |transform| be |capturedElement|'s [=captured element/old styles=]'s 'transform' property.
10771081

1078-
1. Let |width| be |capturedElement|'s [=old styles=]'s 'width' property.
1082+
1. Let |width| be |capturedElement|'s [=captured element/old styles=]'s 'width' property.
10791083

1080-
1. Let |height| be |capturedElement|'s [=old styles=]'s 'height' property.
1084+
1. Let |height| be |capturedElement|'s [=captured element/old styles=]'s 'height' property.
10811085

10821086
1. Set |capturedElement|'s [=captured element/group keyframes=] to a new {{CSSKeyframesRule}} representing the following CSS,
10831087
and append it to |document|'s [=document/view transition style sheet=]:
@@ -1149,15 +1153,15 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn;
11491153

11501154
1. If |capturedElement|'s [=new element=] is null, then:
11511155

1152-
1. Set |width| to |capturedElement|'s [=old styles=] 'width' property.
1156+
1. Set |width| to |capturedElement|'s [=captured element/old styles=] 'width' property.
11531157

1154-
1. Set |height| to |capturedElement|'s [=old styles=] 'height' property.
1158+
1. Set |height| to |capturedElement|'s [=captured element/old styles=] 'height' property.
11551159

1156-
1. Set |transform| to |capturedElement|'s [=old styles=] 'transform' property.
1160+
1. Set |transform| to |capturedElement|'s [=captured element/old styles=] 'transform' property.
11571161

1158-
1. Set |writingMode| to |capturedElement|'s [=old styles=] 'writing-mode' property.
1162+
1. Set |writingMode| to |capturedElement|'s [=captured element/old styles=] 'writing-mode' property.
11591163

1160-
1. Set |direction| to |capturedElement|'s [=old styles=] 'direction' property.
1164+
1. Set |direction| to |capturedElement|'s [=captured element/old styles=] 'direction' property.
11611165

11621166
1. Otherwise:
11631167

0 commit comments

Comments
 (0)