add "print format" signal to perl

fix syntax in signals.txt with regards to GLists

simplify signal emit code

Author: ailin-nemui

docs/signals.txt

@@ -251,7 +251,7 @@ FE common
 * Provides signals:
 
 completion.c:
- "complete word", GList * of char*, WINDOW_REC, char *word, char *linestart, int *want_space
+ "complete word", GList * of char *s, WINDOW_REC, char *word, char *linestart, int *want_space
 
 fe-common-core.c:
  "irssi init read settings"
@@ -285,6 +285,8 @@ keyboard.c:
 
 printtext.c:
  "print text", TEXT_DEST_REC *dest, char *text, char *stripped
+ "print format", THEME_REC *theme, char *module, TEXT_DEST_REC *dest, formatnum_args
+ "print noformat", TEXT_DEST_REC *dest, char *text
 
 themes.c:
  "theme created", THEME_REC

src/fe-common/core/fe-log.c

@@ -570,10 +570,10 @@ static void sig_print_format(THEME_REC *theme, const char *module,
 
 	str = format_get_text_theme_charargs(log_theme, module, dest,
 					     GPOINTER_TO_INT(formatnum), args);
-	skip_next_printtext = TRUE;
+	if (str != NULL && *str != '\0') {
+		skip_next_printtext = TRUE;
 
-	if (*str != '\0') {
-                /* add the line start format */
+		/* add the line start format */
 		linestart = format_get_level_tag(log_theme, dest);
                 tmp = str;
 		str = format_add_linestart(tmp, linestart);

src/fe-common/core/formats.c

@@ -650,6 +650,9 @@ char *format_get_text_theme_charargs(THEME_REC *theme, const char *module,
 	MODULE_THEME_REC *module_theme;
 	char *text;
 
+	if (module == NULL)
+		return NULL;
+
 	module_theme = g_hash_table_lookup(theme->modules, module);
 	if (module_theme == NULL)
 		return NULL;

src/fe-text/textbuffer-formats.c

@@ -124,6 +124,9 @@ static void sig_print_format(THEME_REC *theme, const char *module, TEXT_DEST_REC
 	if (!scrollback_format)
 		return;
 
+	if (module == NULL)
+		return;
+
 	info = store_lineinfo_tmp(dest);
 
 	formatnum = GPOINTER_TO_INT(formatnump);

src/perl/common/Core.xs

@@ -68,13 +68,15 @@ static void add_tuple(gpointer key_, gpointer value_, gpointer user_data)
 	(void) hv_store(hash, key, strlen(key), new_pv(value), 0);
 }
 
-static void wrap_signal_emit(void *signal, void **p) {
-	signal_emit(signal, 6, p[0], p[1], p[2], p[3], p[4], p[5]);
+static void wrap_signal_emit(void *signal, int params, void **p)
+{
+	signal_emit(signal, params, p[0], p[1], p[2], p[3], p[4], p[5]);
 }
 
-static void wrap_signal_continue(void *dummy, void **p) {
+static void wrap_signal_continue(void *dummy, int params, void **p)
+{
 	(void)dummy;
-	signal_continue(6, p[0], p[1], p[2], p[3], p[4], p[5]);
+	signal_continue(params, p[0], p[1], p[2], p[3], p[4], p[5]);
 }
 
 MODULE = Irssi::Core  PACKAGE = Irssi
@@ -85,33 +87,14 @@ signal_emit(signal, ...)
 	char *signal
 CODE:
 	int signal_id;
-	SV *args[SIGNAL_MAX_ARGUMENTS];
-	int n, used;
 
 	signal_id = signal_get_uniq_id(signal);
-	used = items - 1;
-	if (used > SIGNAL_MAX_ARGUMENTS) {
-		used = SIGNAL_MAX_ARGUMENTS;
-	}
-	for (n = 0; n < used; ++n) {
-		args[n] = ST(n + 1);
-	}
-	perl_signal_args_to_c(wrap_signal_emit, signal, signal_id, args, used);
+	perl_signal_args_to_c(wrap_signal_emit, signal, signal_id, &ST(1), items - 1);
 
 void
 signal_continue(...)
 CODE:
-	SV *args[SIGNAL_MAX_ARGUMENTS];
-	int n, used;
-
-	used = items;
-	if (used > SIGNAL_MAX_ARGUMENTS) {
-		used = SIGNAL_MAX_ARGUMENTS;
-	}
-	for (n = 0; n < used; ++n) {
-		args[n] = ST(n);
-	}
-	perl_signal_args_to_c(wrap_signal_continue, NULL, signal_get_emitted_id(), args, used);
+	perl_signal_args_to_c(wrap_signal_continue, NULL, signal_get_emitted_id(), &ST(0), items);
 
 void
 signal_add(...)
@@ -162,7 +145,7 @@ PREINIT:
 	HV *hv;
         HE *he;
 	I32 len, pos;
-	const char *arr[7];
+	const char *arr[SIGNAL_MAX_ARGUMENTS + 1];
 CODE:
 	if (items != 1 || !is_hvref(ST(0)))
 		croak("Usage: Irssi::signal_register(hash)");
@@ -179,7 +162,8 @@ CODE:
 
 		av = (AV *) SvRV(val);
 		len = av_len(av)+1;
-		if (len > 6) len = 6;
+		if (len > SIGNAL_MAX_ARGUMENTS)
+			len = SIGNAL_MAX_ARGUMENTS;
 		for (pos = 0; pos < len; pos++) {
                 	SV **val = av_fetch(av, pos, 0);
 			arr[pos] = SvPV_nolen(*val);

src/perl/get-signals.pl

@@ -16,14 +16,15 @@
 	$signal = $1;
 	$_ = $3;
 
-	s/GList \* of ([^,]*)/glistptr_\1/g;
-	s/GSList of (\w+)s/gslist_\1/g;
+	s/GList \* of ([^,]*)s/glistptr_\1/g;
+	s/GSList of ([^,]*)s/gslist_\1/g;
 
 	s/char \*[^,]*/string/g;
 	s/ulong \*[^,]*/ulongptr/g;
 	s/int \*[^,]*/intptr/g;
 	s/int [^,]*/int/g;
 
+
 	my %map = (
 		# core
 		CHATNET_REC   => 'iobject',