Invalid use of == to compare Character equality; add tests to detect this

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398357 13f79535-47bb-0310-9956-ffa450edef68

Author: sebbASF

src/main/java/org/apache/commons/csv/CSVFormat.java

@@ -205,12 +205,12 @@ void validate() throws IllegalStateException {
                     "')");
         }
 
-        if (quoteChar != null && quoteChar == commentStart) {
+        if (quoteChar != null && quoteChar.equals(commentStart)) {
             throw new IllegalStateException("The comment start character and the quoteChar cannot be the same ('" + commentStart + 
                     "')");
         }
 
-        if (escape != null && escape == commentStart) {
+        if (escape != null && escape.equals(commentStart)) {
             throw new IllegalStateException("The comment start and the escape character cannot be the same ('" + commentStart + "')");
         }
 

src/test/java/org/apache/commons/csv/CSVFormatTest.java

@@ -140,6 +140,14 @@ public void testValidation() {
             // expected
         }
 
+        // Cannot assume that callers won't use different Character objects
+        try {
+            format.withQuoteChar(new Character('!')).withCommentStart('!').validate();
+            fail();
+        } catch (final IllegalStateException e) {
+            // expected
+        }
+
         format.withQuoteChar(null).withCommentStart(null).validate();
 
         try {
@@ -149,6 +157,14 @@ public void testValidation() {
             // expected
         }
 
+        // Cannot assume that callers won't use different Character objects
+        try {
+            format.withEscape(new Character('!')).withCommentStart(new Character('!')).validate();
+            fail();
+        } catch (final IllegalStateException e) {
+            // expected
+        }
+
         format.withEscape(null).withCommentStart(null).validate();
 
 
@@ -165,7 +181,7 @@ public void testValidation() {
         } catch (final IllegalStateException e) {
             // expected
         }
-}
+    }
 
     @SuppressWarnings("boxing") // no need to worry about boxing here
     @Test