FindBugs: Avoid possible NPE.

garydgregory · garydgregory · commit c52b1f0a9d85 · 2016-01-18T20:54:16.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1725345 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/test/java/org/apache/commons/csv/CSVFileParserTest.java b/src/test/java/org/apache/commons/csv/CSVFileParserTest.java
@@ -79,10 +79,10 @@ public boolean accept(final File dir, final String name) {
             }
         };
         final File[] files = BASE.listFiles(filenameFilter);
-        for (final File f : files) {
-            list.add(new Object[] {
-                f
-            });
+        if (files != null) {
+            for (final File f : files) {
+                list.add(new Object[] { f });
+            }
         }
         return list;
     }

Original file line number	Diff line number	Diff line change
`@@ -79,10 +79,10 @@ public boolean accept(final File dir, final String name) {`
`79`	`79`	`}`
`80`	`80`	`};`
`81`	`81`	`final File[] files = BASE.listFiles(filenameFilter);`
`82`		`- for (final File f : files) {`
`83`		`- list.add(new Object[] {`
`84`		`- f`
`85`		`- });`
	`82`	`+ if (files != null) {`
	`83`	`+ for (final File f : files) {`
	`84`	`+ list.add(new Object[] { f });`
	`85`	`+ }`
`86`	`86`	`}`
`87`	`87`	`return list;`
`88`	`88`	`}`