Skip to content

Grid: swap columns and rows in comments #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msarris opened this issue Mar 8, 2017 · 1 comment
Closed

Grid: swap columns and rows in comments #74

msarris opened this issue Mar 8, 2017 · 1 comment

Comments

@msarris
Copy link

msarris commented Mar 8, 2017

In the Grid guide there are a few comments like the following:

.grid-container {
  grid-template-columns: 150px 150px 150px; /* three rows  */
  grid-template-rows: 150px 150px; /* two columns  */
}

https://tympanus.net/codrops/css_reference/grid/#section_grid-tracks-cells

Maybe I misunderstand, but shouldn't rows and columns be swapped in the comments?

@huijing
Copy link
Collaborator

huijing commented Mar 9, 2017

You are absolutely right. Post has been corrected.

@huijing huijing closed this as completed Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants