Skip to content

Commit cf2fcfa

Browse files
committed
Issue 211: new cloning method for date- and rangeinput
1 parent a69f655 commit cf2fcfa

File tree

3 files changed

+13
-22
lines changed

3 files changed

+13
-22
lines changed

src/dateinput/dateinput.js

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -205,16 +205,13 @@
205205

206206
// Replace built-in date input: NOTE: input.attr("type", "text") throws exception by the browser
207207
if (input.attr("type") == 'date') {
208-
209-
original = input.clone();
210-
var tmp = $("<input/>");
208+
var original = input.clone(),
209+
def = original.wrap("<div/>").parent().html(),
210+
clone = $(def.replace(/type/i, "type=text data-orig-type"));
211211

212-
$.each("class,disabled,id,maxlength,name,placeholder,readonly,required,size,style,tabindex,title,value".split(","), function(i, attr) {
213-
tmp.attr(attr, input.attr(attr));
214-
});
215-
216-
input.replaceWith(tmp);
217-
input = tmp;
212+
clone.val(conf.value);
213+
input.replaceWith(clone);
214+
input = clone;
218215
}
219216
input.addClass(css.input);
220217

src/rangeinput/rangeinput.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -175,14 +175,13 @@
175175
}
176176

177177
// Replace built-in range input (type attribute cannot be changed)
178-
if (input.attr("type") == 'range') {
179-
var tmp = $("<input/>");
180-
$.each("class,disabled,id,maxlength,name,placeholder,readonly,required,size,style,tabindex,title,value".split(","), function(i, attr) {
181-
tmp.attr(attr, input.attr(attr));
182-
});
183-
tmp.val(conf.value);
184-
input.replaceWith(tmp);
185-
input = tmp;
178+
if (input.attr("type") == 'range') {
179+
var def = input.clone().wrap("<div/>").parent().html(),
180+
clone = $(def.replace(/type/i, "type=text data-orig-type"));
181+
182+
clone.val(conf.value);
183+
input.replaceWith(clone);
184+
input = clone;
186185
}
187186

188187
input.addClass(css.input);

src/scrollable/scrollable.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,15 +204,10 @@
204204

205205
var cloned1 = self.getItems().slice(-1).clone().prependTo(itemWrap),
206206
cloned2 = self.getItems().eq(1).clone().appendTo(itemWrap);
207-
208-
/* var items = self.getItems(),
209-
cloned1 = items.slice(-1).clone().prependTo(itemWrap),
210-
cloned2 = items.filter(":lt(" + conf.size + ")").clone().appendTo(itemWrap); */
211207

212208
cloned1.add(cloned2).addClass(conf.clonedClass);
213209

214210
self.onBeforeSeek(function(e, i, time) {
215-
216211

217212
if (e.isDefaultPrevented()) { return; }
218213

0 commit comments

Comments
 (0)