Skip to content

Commit 11e7b1c

Browse files
authored
UploadMediaDetailInputFilter: added pattern to identify colon (#5451)
Added hex code of colon for MediaDetailInputFilter and updated test for it.
1 parent 1aa07f9 commit 11e7b1c

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailInputFilter.java

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ public UploadMediaDetailInputFilter() {
2020
Pattern.compile("[\\x{00A0}\\x{1680}\\x{180E}\\x{2000}-\\x{200B}\\x{2028}\\x{2029}\\x{202F}\\x{205F}]"),
2121
Pattern.compile("[\\x{202A}-\\x{202E}]"),
2222
Pattern.compile("\\p{Cc}"),
23+
Pattern.compile("\\x{3A}"), // Added for colon(:)
2324
Pattern.compile("\\x{FEFF}"),
2425
Pattern.compile("\\x{00AD}"),
2526
Pattern.compile("[\\x{E000}-\\x{F8FF}\\x{FFF0}-\\x{FFFF}]"),

app/src/test/kotlin/fr/free/nrw/commons/upload/UploadMediaDetailInputFilterTest.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class UploadMediaDetailInputFilterTest {
6161
builder.filters = arrayOf(UploadMediaDetailInputFilter())
6262

6363
//Sample of control characters
64-
val tests = intArrayOf(0x00, 0x08, 0x10, 0x18, 0x1F, 0x7F)
64+
val tests = intArrayOf(0x00, 0x08, 0x10, 0x18, 0x1F, 0x7F, 0x3A)
6565
for (test: Int in tests) {
6666
builder.insert(0, String(Character.toChars(test)))
6767
Assert.assertEquals(builder.toString(), "")

0 commit comments

Comments
 (0)