Merge pull request #619 from f4ww4z/replace-clear

Replace 'removeAll(c)' with 'clear()'

Author: whym

app/src/main/java/fr/free/nrw/commons/Media.java

@@ -173,7 +173,7 @@ public ArrayList<String> getCategories() {
     }
 
     public void setCategories(List<String> categories) {
-        this.categories.removeAll(this.categories);
+        this.categories.clear();
         this.categories.addAll(categories);
     }
 

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

@@ -235,7 +235,7 @@ protected void onPostExecute(Boolean success) {
                         coordinates.setText(prettyCoordinates(media));
                         uploadedDate.setText(prettyUploadedDate(media));
 
-                        categoryNames.removeAll(categoryNames);
+                        categoryNames.clear();
                         categoryNames.addAll(media.getCategories());
 
                         categoriesLoaded = true;
@@ -280,7 +280,7 @@ public void onLoadingComplete(String s, View view, Bitmap bitmap) {
                     desc.setText(prettyDescription(media));
                     license.setText(prettyLicense(media));
 
-                    categoryNames.removeAll(categoryNames);
+                    categoryNames.clear();
                     categoryNames.addAll(media.getCategories());
 
                     categoriesLoaded = true;