Fixes #3784 (#3787)

* Added empty constructor in ContributionsListFragment
* Initialise ContributionsListFragment's callaback in onAttach

Author: ashishkumar468

app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java

@@ -223,7 +223,7 @@ void onAuthCookieAcquired() {
 
     private void initFragments() {
         if (null == contributionsListFragment) {
-            contributionsListFragment = new ContributionsListFragment(this);
+            contributionsListFragment = new ContributionsListFragment();
         }
 
         if (shouldShowMediaDetailsFragment) {

app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java

@@ -3,6 +3,7 @@
 import static android.view.View.GONE;
 import static android.view.View.VISIBLE;
 
+import android.content.Context;
 import android.content.res.Configuration;
 import android.os.Bundle;
 import android.os.Parcelable;
@@ -71,14 +72,11 @@ public class ContributionsListFragment extends CommonsDaggerSupportFragment impl
 
   private ContributionsListAdapter adapter;
 
-  private final Callback callback;
+  private Callback callback;
 
   private final int SPAN_COUNT_LANDSCAPE = 3;
   private final int SPAN_COUNT_PORTRAIT = 1;
 
-  ContributionsListFragment(final Callback callback) {
-    this.callback = callback;
-  }
 
   public View onCreateView(
       final LayoutInflater inflater, @Nullable final ViewGroup container,
@@ -90,6 +88,20 @@ public View onCreateView(
     return view;
   }
 
+  @Override
+  public void onAttach(Context context) {
+    super.onAttach(context);
+    if (getParentFragment() != null && getParentFragment() instanceof ContributionsFragment) {
+      callback = ((ContributionsFragment) getParentFragment());
+    }
+  }
+
+  @Override
+  public void onDetach() {
+    super.onDetach();
+    callback = null;//To avoid possible memory leak
+  }
+
   private void initAdapter() {
     adapter = new ContributionsListAdapter(this, mediaClient);
   }
@@ -203,7 +215,9 @@ public void onViewStateRestored(@Nullable Bundle savedInstanceState) {
 
   @Override
   public void retryUpload(final Contribution contribution) {
-    callback.retryUpload(contribution);
+    if (null != callback) {//Just being safe, ideally they won't be called when detached
+      callback.retryUpload(contribution);
+    }
   }
 
   @Override
@@ -213,7 +227,9 @@ public void deleteUpload(final Contribution contribution) {
 
   @Override
   public void openMediaDetail(final int position) {
-    callback.showDetail(position);
+    if (null != callback) {//Just being safe, ideally they won't be called when detached
+      callback.showDetail(position);
+    }
   }
 
   public Media getMediaAtPosition(final int i) {